Issue 10237012: Don't read Linux host configuration if binary is not on path.

Issue 10237012: Don't read Linux host configuration if binary is not on path. (Closed)

Created:
8 years, 8 months ago by Wez

Modified:
8 years, 8 months ago

Reviewers:
Sergey Ulanov

CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Don't read Linux host configuration if binary is not on path. BUG=125217 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134450

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addres comment. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+20 lines, -16 lines)			Patch
	M	remoting/host/plugin/daemon_controller.h	View		1 chunk	+4 lines, -6 lines	0 comments	Download
	M	remoting/host/plugin/daemon_controller_linux.cc	View	1	1 chunk	+16 lines, -10 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Sergey Ulanov

lgtm http://codereview.chromium.org/10237012/diff/1/remoting/host/plugin/daemon_controller_linux.cc File remoting/host/plugin/daemon_controller_linux.cc (right): http://codereview.chromium.org/10237012/diff/1/remoting/host/plugin/daemon_controller_linux.cc#newcode202 remoting/host/plugin/daemon_controller_linux.cc:202: result->SetString(kHostIdConfigPath, value); nit: add {} to match style ...

8 years, 8 months ago (2012-04-27 01:29:22 UTC) #2

Wez

http://codereview.chromium.org/10237012/diff/1/remoting/host/plugin/daemon_controller_linux.cc File remoting/host/plugin/daemon_controller_linux.cc (right): http://codereview.chromium.org/10237012/diff/1/remoting/host/plugin/daemon_controller_linux.cc#newcode202 remoting/host/plugin/daemon_controller_linux.cc:202: result->SetString(kHostIdConfigPath, value); On 2012/04/27 01:29:22, sergeyu wrote: > nit: ...

8 years, 8 months ago (2012-04-28 05:16:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wez@chromium.org/10237012/5001

8 years, 8 months ago (2012-04-28 05:16:46 UTC) #4

Change committed as 134450

Expand Messages | Collapse Messages