Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Unified Diff: remoting/host/plugin/daemon_controller.h

Issue 10237012: Don't read Linux host configuration if binary is not on path. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addres comment. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | remoting/host/plugin/daemon_controller_linux.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: remoting/host/plugin/daemon_controller.h
diff --git a/remoting/host/plugin/daemon_controller.h b/remoting/host/plugin/daemon_controller.h
index 93810ea6aaa0936b0f679302abbf85ed939c514d..281d258d96b7907cb3804521900fcb6d6725d198 100644
--- a/remoting/host/plugin/daemon_controller.h
+++ b/remoting/host/plugin/daemon_controller.h
@@ -65,12 +65,10 @@ class DaemonController {
// them in the webapp.
};
- // The callback for GetConfig(). |config| is set to NULL in case of
- // an error. Otherwise it is a dictionary that contains only the
- // following values: host_id and xmpp_login, which may be empty if
- // the host is not initialized yet. All other values are filtered out of the
- // config before this callback is invoked: they may contain security
- // sensitive information, such as authentication tokens and private keys.
+ // Callback type for GetConfig(). If the host is configured then a dictionary
+ // is returned containing host_id and xmpp_login, with security-sensitive
+ // fields filtered out. An empty dictionary is returned if the host is not
+ // configured, and NULL if the configuration is corrupt or cannot be read.
typedef base::Callback<void (scoped_ptr<base::DictionaryValue> config)>
GetConfigCallback;
« no previous file with comments | « no previous file | remoting/host/plugin/daemon_controller_linux.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698