Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(156)

Issue 10233016: Add a new UMA histogram for tracking SpdySessionErrorDetails (Closed)

Created:
8 years, 8 months ago by Ryan Hamilton
Modified:
8 years, 8 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add a new UMA histogram for tracking SpdySessionErrorDetails BUG=125213 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134442

Patch Set 1 : #

Patch Set 2 : Cleanup #

Total comments: 2

Patch Set 3 : Track all protocol errors, not just fatal session errors. #

Patch Set 4 : Correctly handle SpdyStatusCodes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -0 lines) Patch
M net/spdy/spdy_session.h View 1 2 3 2 chunks +45 lines, -0 lines 0 comments Download
M net/spdy/spdy_session.cc View 1 2 3 10 chunks +25 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Ryan Hamilton
Hi Will, Please take a look. This CL adds a histogram for SPDY session errors, ...
8 years, 8 months ago (2012-04-27 16:22:59 UTC) #1
willchan no longer on Chromium
lgtm http://codereview.chromium.org/10233016/diff/4001/net/spdy/spdy_session.h File net/spdy/spdy_session.h (right): http://codereview.chromium.org/10233016/diff/4001/net/spdy/spdy_session.h#newcode68 net/spdy/spdy_session.h:68: REQUST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION, REQUEST http://codereview.chromium.org/10233016/diff/4001/net/spdy/spdy_session.h#newcode74 net/spdy/spdy_session.h:74: COMPILE_ASSERT(static_cast<SpdySessionErrorDetails>(SpdyFramer::LAST_ERROR) == include compiler_specific.h ...
8 years, 8 months ago (2012-04-27 21:59:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10233016/13001
8 years, 8 months ago (2012-04-27 23:32:32 UTC) #3
commit-bot: I haz the power
Try job failure for 10233016-13001 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-27 23:58:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10233016/13001
8 years, 8 months ago (2012-04-28 03:43:18 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-28 05:45:14 UTC) #6
Change committed as 134442

Powered by Google App Engine
This is Rietveld 408576698