Add a new UMA histogram for tracking SpdySessionErrorDetails

net/spdy/spdy_session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef NET_SPDY_SPDY_SESSION_H_
 #define NET_SPDY_SPDY_SESSION_H_
 #pragma once
 
 #include <algorithm>
 #include <list>
@@ skipping 31 matching lines @@
 // reasonably with ethernet. Chop the world into 2-packet chunks.  This is
 // somewhat arbitrary, but is reasonably small and ensures that we elicit
 // ACKs quickly from TCP (because TCP tries to only ACK every other packet).
 const int kMss = 1430;
 const int kMaxSpdyFrameChunkSize = (2 * kMss) - SpdyFrame::kHeaderSize;
 
 class BoundNetLog;
 class SpdyStream;
 class SSLInfo;
 
+enum SpdySessionErrorDetails {
+  // SpdyFramer::SpdyErrors
+  SPDY_NO_ERROR,
+  SPDY_INVALID_CONTROL_FRAME,      // Control frame is mal-formatted.
+  SPDY_CONTROL_PAYLOAD_TOO_LARGE,  // Control frame payload was too large.
+  SPDY_ZLIB_INIT_FAILURE,          // The Zlib library could not initialize.
+  SPDY_UNSUPPORTED_VERSION,        // Control frame has unsupported version.
+  SPDY_DECOMPRESS_FAILURE,         // There was an error decompressing.
+  SPDY_COMPRESS_FAILURE,           // There was an error compressing.
+  SPDY_CREDENTIAL_FRAME_CORRUPT,   // CREDENTIAL frame could not be parsed.
+  SPDY_INVALID_DATA_FRAME_FLAGS,   // Data frame has invalid flags.
+
+  // SpdySession errors
+  UNEXPECTED_PING,
+  PING_FAILED,
+  SPDY_COMPRESSION_FAILURE,
+  REQUST_FOR_SECURE_CONTENT_OVER_INSECURE_SESSION,

[willchan no longer on Chromium, 2012/04/27 21:59:30]

REQUEST

+  READ_FAILED,
+  WRITE_FAILED,
+  NUM_SPDY_SESSION_ERROR_DETAILS
+};
+
+COMPILE_ASSERT(static_cast<SpdySessionErrorDetails>(SpdyFramer::LAST_ERROR) ==

[willchan no longer on Chromium, 2012/04/27 21:59:30]

include compiler_specific.h for this

+               UNEXPECTED_PING,
+               SpdySessionErrorDetails_SpdyErrors_mismatch);
+
 class NET_EXPORT SpdySession : public base::RefCounted<SpdySession>,
                                public BufferedSpdyFramerVisitorInterface {
  public:
   // Create a new SpdySession.
   // |host_port_proxy_pair| is the host/port that this session connects to, and
   // the proxy configuration settings that it's using.
   // |spdy_session_pool| is the SpdySessionPool that owns us.  Its lifetime must
   // strictly be greater than |this|.
   // |session| is the HttpNetworkSession.  |net_log| is the NetLog that we log
   // network events to.
@@ skipping 137 matching lines @@
   bool IsClosed() const { return state_ == CLOSED; }
 
   // Closes this session.  This will close all active streams and mark
   // the session as permanently closed.
   // |err| should not be OK; this function is intended to be called on
   // error.
   // |remove_from_pool| indicates whether to also remove the session from the
   // session pool.
   // |description| indicates the reason for the error.
   void CloseSessionOnError(net::Error err,
+                           SpdySessionErrorDetails details,
                            bool remove_from_pool,
                            const std::string& description);
 
   // Retrieves information on the current state of the SPDY session as a
   // Value.  Caller takes possession of the returned value.
   base::Value* GetInfoAsValue() const;
 
   // Indicates whether the session is being reused after having successfully
   // used to send/receive data in the past.
   bool IsReused() const;
@@ skipping 203 matching lines @@
   void RecordHistograms();
 
   // Closes all streams.  Used as part of shutdown.
   void CloseAllStreams(net::Error status);
 
   // Invokes a user callback for stream creation.  We provide this method so it
   // can be deferred to the MessageLoop, so we avoid re-entrancy problems.
   void InvokeUserStreamCreationCallback(scoped_refptr<SpdyStream>* stream);
 
   // BufferedSpdyFramerVisitorInterface:
-  virtual void OnError(int error_code) OVERRIDE;
+  virtual void OnError(SpdyFramer::SpdyError error_code) OVERRIDE;
   virtual void OnStreamError(SpdyStreamId stream_id,
                              const std::string& description) OVERRIDE;
   virtual void OnRstStream(
       const SpdyRstStreamControlFrame& frame) OVERRIDE;
   virtual void OnGoAway(const SpdyGoAwayControlFrame& frame) OVERRIDE;
   virtual void OnPing(const SpdyPingControlFrame& frame) OVERRIDE;
   virtual void OnWindowUpdate(
       const SpdyWindowUpdateControlFrame& frame) OVERRIDE;
   virtual void OnStreamFrameData(SpdyStreamId stream_id,
                                  const char* data,
@@ skipping 258 matching lines @@
 
   const int status_;
   const std::string description_;
 
   DISALLOW_COPY_AND_ASSIGN(NetLogSpdySessionCloseParameter);
 };
 
 }  // namespace net
 
 #endif  // NET_SPDY_SPDY_SESSION_H_