Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(480)

Issue 10225017: Explicitly track the time source type in base/profiler/alternate_timer.h (Closed)

Created:
8 years, 8 months ago by Ilya Sherman
Modified:
8 years, 8 months ago
CC:
chromium-reviews, erikwright (departed), MAD, Ilya Sherman, jar (doing other things), brettw-cc_chromium.org
Visibility:
Public.

Description

Explicitly track the time source type in base/profiler/alternate_timer.h We were previously implicitly tracking the time source as either default or tcmalloc-based; but as we add more time sources (e.g. cpu time), we'll want to have explicit tracking for this. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134041

Patch Set 1 #

Patch Set 2 : Missed a spot.. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -5 lines) Patch
M base/allocator/allocator_shim.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M base/profiler/alternate_timer.h View 1 2 chunks +10 lines, -2 lines 2 comments Download
M base/profiler/alternate_timer.cc View 1 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/metrics/metrics_log.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Ilya Sherman
8 years, 8 months ago (2012-04-25 23:37:07 UTC) #1
jar (doing other things)
See nit below. I'm *guessing* this will break some funky dll builds if you don't ...
8 years, 8 months ago (2012-04-26 00:00:11 UTC) #2
Ilya Sherman
https://chromiumcodereview.appspot.com/10225017/diff/2001/base/profiler/alternate_timer.h File base/profiler/alternate_timer.h (left): https://chromiumcodereview.appspot.com/10225017/diff/2001/base/profiler/alternate_timer.h#oldcode31 base/profiler/alternate_timer.h:31: BASE_EXPORT NowFunction* GetAlternateTimeSource(); On 2012/04/26 00:00:11, jar wrote: > ...
8 years, 8 months ago (2012-04-26 00:05:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/isherman@chromium.org/10225017/2001
8 years, 8 months ago (2012-04-26 00:06:57 UTC) #4
commit-bot: I haz the power
8 years, 8 months ago (2012-04-26 01:40:55 UTC) #5
Change committed as 134041

Powered by Google App Engine
This is Rietveld 408576698