Chromium Code Reviews Chromium Code Reviews
Issue 10222017:
Make password generation switched by a preference in chrome settings rather than a command line fla… (Closed)
Base URL: svn://svn.chromium.org/chrome/trunk/src| OLD | NEW |
|---|---|
| 1 <div id="settings" class="page" hidden> | 1 <div id="settings" class="page" hidden> |
| 2 <header> | 2 <header> |
| 3 <h1 i18n-content="settingsTitle"></h1> | 3 <h1 i18n-content="settingsTitle"></h1> |
| 4 </header> | 4 </header> |
| 5 <if expr="not pp_ifdef('chromeos')"> | 5 <if expr="not pp_ifdef('chromeos')"> |
| 6 <include src="sync_section.html"> | 6 <include src="sync_section.html"> |
| 7 </if> | 7 </if> |
| 8 <if expr="pp_ifdef('chromeos')"> | 8 <if expr="pp_ifdef('chromeos')"> |
| 9 <section> | 9 <section> |
| 10 <h3 i18n-content="sectionTitleInternet"></h3> | 10 <h3 i18n-content="sectionTitleInternet"></h3> |
| (...skipping 293 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 304 <label> | 304 <label> |
| 305 <input id="password-manager-enabled" | 305 <input id="password-manager-enabled" |
| 306 pref="profile.password_manager_enabled" | 306 pref="profile.password_manager_enabled" |
| 307 metric="Options_PasswordManager" type="checkbox"> | 307 metric="Options_PasswordManager" type="checkbox"> |
| 308 <span i18n-content="passwordManagerEnabled"></span> | 308 <span i18n-content="passwordManagerEnabled"></span> |
| 309 </label> | 309 </label> |
| 310 <button id="manage-passwords" class="link-button" | 310 <button id="manage-passwords" class="link-button" |
| 311 i18n-content="managePasswords" | 311 i18n-content="managePasswords" |
| 312 pref="profile.password_manager_enabled"></button> | 312 pref="profile.password_manager_enabled"></button> |
| 313 </div> | 313 </div> |
| 314 <div class="checkbox" id="passwordGenerationCheckbox"> | |
|
Ilya Sherman
2012/05/04 06:04:50
nit: Ids should use hyphenated-name-casing
zysxqn
2012/05/04 18:52:54
Done.
| |
| 315 <label> | |
| 316 <input id="passwordGenerationEnabled" pref="password_generation.enabled" | |
|
Ilya Sherman
2012/05/04 06:04:50
nit: Ditto, though in this case perhaps we can rem
zysxqn
2012/05/04 18:52:54
Done.
| |
| 317 metric="Options_PasswordGenerationCheckbox" type="checkbox"> | |
| 318 <span i18n-content="passwordGenerationEnabledDescription"></span> | |
| 319 </label> | |
| 320 </div> | |
| 314 <if expr="is_macosx"> | 321 <if expr="is_macosx"> |
| 315 <div id="mac-passwords-warning" i18n-content="macPasswordsWarning" hidden> | 322 <div id="mac-passwords-warning" i18n-content="macPasswordsWarning" hidden> |
| 316 </div> | 323 </div> |
| 317 </if> | 324 </if> |
| 318 <!-- This makes the managed-banner appear when the "pref" is configured by | 325 <!-- This makes the managed-banner appear when the "pref" is configured by |
| 319 the IT administrator. --> | 326 the IT administrator. --> |
| 320 <input name="password_allow_show_hidden" type="text" | 327 <input name="password_allow_show_hidden" type="text" |
| 321 pref="profile.password_manager_allow_show_passwords" hidden> | 328 pref="profile.password_manager_allow_show_passwords" hidden> |
| 322 </section> | 329 </section> |
| 323 <section id="web-content-section"> | 330 <section id="web-content-section"> |
| (...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 498 </section> | 505 </section> |
| 499 </if> | 506 </if> |
| 500 </div> <!-- advanced-settings-container --> | 507 </div> <!-- advanced-settings-container --> |
| 501 </div> <!-- advanced-settings --> | 508 </div> <!-- advanced-settings --> |
| 502 <footer> | 509 <footer> |
| 503 <button id="advanced-settings-expander" class="link-button" | 510 <button id="advanced-settings-expander" class="link-button" |
| 504 i18n-content="showAdvancedSettings"> | 511 i18n-content="showAdvancedSettings"> |
| 505 </button> | 512 </button> |
| 506 </footer> | 513 </footer> |
| 507 </div> | 514 </div> |
| OLD | NEW |
