Issue 10222007: Switch from margin to padding for checkboxes and radio buttons.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10222007: Switch from margin to padding for checkboxes and radio buttons. (Closed)

Created:
8 years, 8 months ago by kevers

Modified:
8 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Switch from margin to padding for checkboxes and radio buttons. BUG=102482 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134528

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -8 lines)			Patch
	M	chrome/browser/resources/shared/css/chrome_shared2_touch.css	View	1	1 chunk	+9 lines, -8 lines	0 comments	Download

Total messages: 5 (0 generated)

kevers

Hi Evan, Can you please have a look at this CL. Switching from margins to ...

8 years, 8 months ago (2012-04-25 17:03:48 UTC) #1

Evan Stade

lgtm with caveat: this will make many things look bad in subtle ways because vertical ...

8 years, 8 months ago (2012-04-25 19:31:01 UTC) #2

kevers

Agreed that margin looks more aesthetically pleasing; however, margins are not touchable without touch fuzzing ...

8 years, 8 months ago (2012-04-25 20:19:21 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kevers@chromium.org/10222007/4002

8 years, 7 months ago (2012-04-30 12:58:26 UTC) #4

Change committed as 134528