Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2846)

Unified Diff: chrome/browser/resources/shared/css/chrome_shared2_touch.css

Issue 10222007: Switch from margin to padding for checkboxes and radio buttons. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Remove margin for checkbox and radio button. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/shared/css/chrome_shared2_touch.css
diff --git a/chrome/browser/resources/shared/css/chrome_shared2_touch.css b/chrome/browser/resources/shared/css/chrome_shared2_touch.css
index 858da24d639efd18fc9127e1626ff3fe6ac21125..5712c04c405c83ae0a7545dde0b8b1b1da95f6e8 100644
--- a/chrome/browser/resources/shared/css/chrome_shared2_touch.css
+++ b/chrome/browser/resources/shared/css/chrome_shared2_touch.css
@@ -14,16 +14,17 @@ input[type='search'] {
padding-top: 6px;
}
-/* Additional padding to disambiguate controls on neighboring rows.
- * Ideally, the margin belongs on input[type=radio|checkbox] to be a more
- * general fix; however, this creates baseline problems as webkit is not
- * currently able to reconcile the baseline of a text-free inline box
- * containing a margin and fixed dimensions with neighboring content.
- * TODO(kevers): Reinvestigate once the baseline adjustment properties in
- * CSS3 are supported. */
+/* Margins are not touchable. Use padding on the inner label instead to
+ increase the size of the touch target. */
.checkbox,
.radio {
- margin: 12px 0;
+ margin: 0;
+}
+
+.checkbox label,
+.radio label {
+ padding-bottom: 7px;
+ padding-top: 7px;
}
li > button.link-button {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698