Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/test/functional/infobars.py

Issue 10217005: Revert back to using WaitUntil for page readyState (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/functional/infobars.py
===================================================================
--- chrome/test/functional/infobars.py (revision 133718)
+++ chrome/test/functional/infobars.py (working copy)
@@ -208,7 +208,12 @@
username = creds['username']
password = creds['password']
test_utils.GoogleAccountsLogin(self, username, password, tab_index, windex)
- self.WaitUntilNavigationCompletes(tab_index=tab_index, windex=windex)
+ # TODO(dyu): Use WaitUntilNavigationCompletes after investigating
+ # crbug.com/124877
+ #self.WaitUntilNavigationCompletes(tab_index=tab_index, windex=windex)
Nirnimesh 2012/04/24 20:13:09 remove commented out code. the TODO is fine.
+ self.WaitUntil(
+ lambda: self.GetDOMValue('document.readyState'),
+ expect_retval='complete')
def _PerformActionOnInfobar(self, action):
"""Perform an action on the infobar: accept, cancel, or dismiss.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698