Revert back to using WaitUntil for page readyState

chrome/test/functional/infobars.py

 #!/usr/bin/env python
 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import logging
 import os
 import re
 
 import pyauto_functional  # Must be imported before pyauto
@@ skipping 190 matching lines @@
     """Log into Google account.
 
     Args:
       tab_index: The tab index, default is 0.
       windex: The window index, default is 0.
     """
     creds = self.GetPrivateInfo()['test_google_account']
     username = creds['username']
     password = creds['password']
     test_utils.GoogleAccountsLogin(self, username, password, tab_index, windex)
-    self.WaitUntilNavigationCompletes(tab_index=tab_index, windex=windex)
+    # TODO(dyu): Use WaitUntilNavigationCompletes after investigating
+    # crbug.com/124877
+    #self.WaitUntilNavigationCompletes(tab_index=tab_index, windex=windex)

[Nirnimesh, 2012/04/24 20:13:09]

remove commented out code. the TODO is fine.

+    self.WaitUntil(
+        lambda: self.GetDOMValue('document.readyState'),
+        expect_retval='complete')
 
   def _PerformActionOnInfobar(self, action):
     """Perform an action on the infobar: accept, cancel, or dismiss.
 
     The one-click sign in infobar must show in the first tab of the first
     window. If action is 'accept' then the account is synced. If the action is
     'cancel' then the infobar should be dismissed and never shown again. The
     account will not be synced. If the action is 'dismiss' then the infobar will
     shown again after the next login.
 
@@ skipping 131 matching lines @@
   def testNoOneClickInfobarInIncognito(self):
     """Verify that one-click infobar does not show up in incognito mode."""
     self.RunCommand(pyauto.IDC_NEW_INCOGNITO_WINDOW)
     self._LogIntoGoogleAccount(windex=1)
     test_utils.AssertInfobarTypeDoesNotAppear(
         self, self.OC_INFOBAR_TYPE, windex=1)
 
 
 if __name__ == '__main__':
   pyauto_functional.Main()