Issue 10216006: Use the correct remaining data length when parsing chunk headers.

Issue 10216006: Use the correct remaining data length when parsing chunk headers. (Closed)

Created:
8 years, 8 months ago by Brian Ryner

Modified:
8 years, 8 months ago

Reviewers:
Scott Hess - ex-Googler, mattm

CC:
chromium-reviews, Garrett Casto, noé

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Use the correct remaining data length when parsing chunk headers. BUG=124853 TEST=SafeBrowsingProtocolParsingTest.TestTruncatedHeader Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133867

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -1 line)			Patch
	M	chrome/browser/safe_browsing/protocol_parser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	chrome/browser/safe_browsing/protocol_parser_unittest.cc	View		1 chunk	+15 lines, -0 lines	0 comments	Download

Total messages: 9 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/10216006/1

8 years, 8 months ago (2012-04-25 02:31:37 UTC) #3

Brian Ryner

fyi this probably never caused an issue until we stopped using MAC'ing, because the MAC ...

8 years, 8 months ago (2012-04-25 03:19:06 UTC) #5

commit-bot: I haz the power

List of reviewers changed. shess@chromium.org did a drive-by without LGTM'ing!

8 years, 8 months ago (2012-04-25 04:09:50 UTC) #6

Scott Hess - ex-Googler

On 2012/04/25 04:09:50, I haz the power (commit-bot) wrote: > List of reviewers changed. mailto:shess@chromium.org ...

8 years, 8 months ago (2012-04-25 04:50:28 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bryner@chromium.org/10216006/1

8 years, 8 months ago (2012-04-25 04:50:59 UTC) #8

Change committed as 133867