chromeos: Break WebUILoginDisplay and SigninScreenHandler coupling on destruction.

chromeos: Break WebUILoginDisplay and SigninScreenHandler coupling on destruction.

So that neither of the two points to an invalid instance.

BUG=chromium-os:29669
TEST=Verify crash in chromium-os:29669 no longer happens.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133959

[altimofeev, 2012-04-25 16:32:26]

LGTM but I think it is a good idea to explicitly handle the cases, when
|webui_handler_| has been NULL-ed.

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/webui_login_display.cc (right):

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:64: DCHECK(webui_handler_);
please handle webui_handler_== NULL case

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:69: DCHECK(webui_handler_);
ditto

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:77:
webui_handler_->OnLoginSuccess(username);
ditto

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:82:
webui_handler_->ClearAndEnablePassword();
ditto

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:94: DCHECK(webui_handler_);
ditto

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:143:
webui_handler_->ShowGaiaPasswordChanged(username);
ditto

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:200:
DCHECK(webui_handler_);
ditto

[xiyuan, 2012-04-25 17:08:10]

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
File chrome/browser/chromeos/login/webui_login_display.cc (right):

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:64: DCHECK(webui_handler_);
On 2012/04/25 16:32:27, altimofeev wrote:
> please handle webui_handler_== NULL case

Done.

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:69: DCHECK(webui_handler_);
On 2012/04/25 16:32:27, altimofeev wrote:
> ditto

Done.

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:77:
webui_handler_->OnLoginSuccess(username);
On 2012/04/25 16:32:27, altimofeev wrote:
> ditto

Done.

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:82:
webui_handler_->ClearAndEnablePassword();
On 2012/04/25 16:32:27, altimofeev wrote:
> ditto

Done.

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:94: DCHECK(webui_handler_);
On 2012/04/25 16:32:27, altimofeev wrote:
> ditto

Done.

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:143:
webui_handler_->ShowGaiaPasswordChanged(username);
On 2012/04/25 16:32:27, altimofeev wrote:
> ditto

Done.

http://codereview.chromium.org/10213003/diff/1/chrome/browser/chromeos/login/...
chrome/browser/chromeos/login/webui_login_display.cc:200:
DCHECK(webui_handler_);
On 2012/04/25 16:32:27, altimofeev wrote:
> ditto

Done.

[commit-bot: I haz the power, 2012-04-25 18:16:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/xiyuan@chromium.org/10213003/4001

[commit-bot: I haz the power, 2012-04-25 19:41:15]

Change committed as 133959