Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Side by Side Diff: chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc

Issue 10213003: chromeos: Break WebUILoginDisplay and SigninScreenHandler coupling on destruction. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: for comments in #1 Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h" 5 #include "chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/bind_helpers.h" 8 #include "base/bind_helpers.h"
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
(...skipping 270 matching lines...) Expand 10 before | Expand all | Expand 10 after
281 CrosSettings::Get()->AddSettingsObserver(kAccountsPrefAllowNewUser, this); 281 CrosSettings::Get()->AddSettingsObserver(kAccountsPrefAllowNewUser, this);
282 CrosSettings::Get()->AddSettingsObserver(kAccountsPrefAllowGuest, this); 282 CrosSettings::Get()->AddSettingsObserver(kAccountsPrefAllowGuest, this);
283 } 283 }
284 284
285 SigninScreenHandler::~SigninScreenHandler() { 285 SigninScreenHandler::~SigninScreenHandler() {
286 weak_factory_.InvalidateWeakPtrs(); 286 weak_factory_.InvalidateWeakPtrs();
287 if (cookie_remover_) 287 if (cookie_remover_)
288 cookie_remover_->RemoveObserver(this); 288 cookie_remover_->RemoveObserver(this);
289 if (key_event_listener_) 289 if (key_event_listener_)
290 key_event_listener_->RemoveCapsLockObserver(this); 290 key_event_listener_->RemoveCapsLockObserver(this);
291 if (delegate_)
292 delegate_->SetWebUIHandler(NULL);
291 CrosSettings::Get()->RemoveSettingsObserver(kAccountsPrefAllowNewUser, this); 293 CrosSettings::Get()->RemoveSettingsObserver(kAccountsPrefAllowNewUser, this);
292 CrosSettings::Get()->RemoveSettingsObserver(kAccountsPrefAllowGuest, this); 294 CrosSettings::Get()->RemoveSettingsObserver(kAccountsPrefAllowGuest, this);
293 } 295 }
294 296
295 void SigninScreenHandler::GetLocalizedStrings( 297 void SigninScreenHandler::GetLocalizedStrings(
296 DictionaryValue* localized_strings) { 298 DictionaryValue* localized_strings) {
297 localized_strings->SetString("signinScreenTitle", 299 localized_strings->SetString("signinScreenTitle",
298 l10n_util::GetStringUTF16(IDS_SIGNIN_SCREEN_TITLE)); 300 l10n_util::GetStringUTF16(IDS_SIGNIN_SCREEN_TITLE));
299 localized_strings->SetString("signinScreenPasswordChanged", 301 localized_strings->SetString("signinScreenPasswordChanged",
300 l10n_util::GetStringUTF16(IDS_SIGNIN_SCREEN_PASSWORD_CHANGED)); 302 l10n_util::GetStringUTF16(IDS_SIGNIN_SCREEN_PASSWORD_CHANGED));
(...skipping 228 matching lines...) Expand 10 before | Expand all | Expand 10 after
529 531
530 void SigninScreenHandler::ShowGaiaPasswordChanged(const std::string& username) { 532 void SigninScreenHandler::ShowGaiaPasswordChanged(const std::string& username) {
531 email_ = username; 533 email_ = username;
532 password_changed_for_.insert(email_); 534 password_changed_for_.insert(email_);
533 base::StringValue email_value(email_); 535 base::StringValue email_value(email_);
534 web_ui()->CallJavascriptFunction("cr.ui.Oobe.showSigninUI", email_value); 536 web_ui()->CallJavascriptFunction("cr.ui.Oobe.showSigninUI", email_value);
535 web_ui()->CallJavascriptFunction( 537 web_ui()->CallJavascriptFunction(
536 "login.AccountPickerScreen.updateUserGaiaNeeded", email_value); 538 "login.AccountPickerScreen.updateUserGaiaNeeded", email_value);
537 } 539 }
538 540
541 void SigninScreenHandler::ResetSigninScreenHandlerDelegate() {
542 SetDelegate(NULL);
543 }
544
539 void SigninScreenHandler::OnBrowsingDataRemoverDone() { 545 void SigninScreenHandler::OnBrowsingDataRemoverDone() {
540 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 546 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
541 cookie_remover_ = NULL; 547 cookie_remover_ = NULL;
542 cookies_cleared_ = true; 548 cookies_cleared_ = true;
543 ShowSigninScreenIfReady(); 549 ShowSigninScreenIfReady();
544 } 550 }
545 551
546 void SigninScreenHandler::OnCapsLockChange(bool enabled) { 552 void SigninScreenHandler::OnCapsLockChange(bool enabled) {
547 if (page_is_ready()) { 553 if (page_is_ready()) {
548 base::FundamentalValue capsLockState(enabled); 554 base::FundamentalValue capsLockState(enabled);
(...skipping 460 matching lines...) Expand 10 before | Expand all | Expand 10 after
1009 !dns_clear_task_running_ && 1015 !dns_clear_task_running_ &&
1010 network_state_informer_->is_online()) { 1016 network_state_informer_->is_online()) {
1011 gaia_silent_load_ = true; 1017 gaia_silent_load_ = true;
1012 gaia_silent_load_network_ = 1018 gaia_silent_load_network_ =
1013 network_state_informer_->active_network_service_path(); 1019 network_state_informer_->active_network_service_path();
1014 LoadAuthExtension(true, true, false); 1020 LoadAuthExtension(true, true, false);
1015 } 1021 }
1016 } 1022 }
1017 1023
1018 } // namespace chromeos 1024 } // namespace chromeos
OLDNEW
« no previous file with comments | « chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698