Issue 10211010: Sync UI: Remove the StopSyncingHandler.

Issue 10211010: Sync UI: Remove the StopSyncingHandler. (Closed)

Created:
8 years, 8 months ago by James Hawkins

Modified:
8 years, 8 months ago

Reviewers:
csilv

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Sync UI: Remove the StopSyncingHandler. Move the few strings and one message handler into SyncSetupHandler, where the rest of the UI lives. BUG=none TEST=none R=csilv Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133965

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixes. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+50 lines, -115 lines)			Patch
M	chrome/browser/resources/sync_setup_overlay.js	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/options2/options_ui2.cc	View	1	2 chunks	+0 lines, -2 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/stop_syncing_handler.h	View		1 chunk	+0 lines, -33 lines	0 comments	Download
D	chrome/browser/ui/webui/options2/stop_syncing_handler.cc	View		1 chunk	+0 lines, -59 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc	View		6 chunks	+23 lines, -16 lines	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.h	View	1	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/webui/sync_setup_handler.cc	View		4 chunks	+24 lines, -1 line	0 comments	Download
M	chrome/chrome_browser.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

csilv

lgtm https://chromiumcodereview.appspot.com/10211010/diff/1/chrome/browser/ui/webui/sync_setup_handler.h File chrome/browser/ui/webui/sync_setup_handler.h (right): https://chromiumcodereview.appspot.com/10211010/diff/1/chrome/browser/ui/webui/sync_setup_handler.h#newcode102 chrome/browser/ui/webui/sync_setup_handler.h:102: void HandleStopSyncing(const ListValue* args); base::ListValue*

8 years, 8 months ago (2012-04-24 23:09:08 UTC) #2

James Hawkins

https://chromiumcodereview.appspot.com/10211010/diff/1/chrome/browser/ui/webui/sync_setup_handler.h File chrome/browser/ui/webui/sync_setup_handler.h (right): https://chromiumcodereview.appspot.com/10211010/diff/1/chrome/browser/ui/webui/sync_setup_handler.h#newcode102 chrome/browser/ui/webui/sync_setup_handler.h:102: void HandleStopSyncing(const ListValue* args); On 2012/04/24 23:09:08, csilv wrote: ...

8 years, 8 months ago (2012-04-25 18:48:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jhawkins@chromium.org/10211010/8001

8 years, 8 months ago (2012-04-25 18:48:54 UTC) #4

Change committed as 133965

Expand Messages | Collapse Messages