Sync UI: Remove the StopSyncingHandler.

chrome/browser/ui/webui/sync_promo/sync_promo_handler.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/sync_promo/sync_promo_handler.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/metrics/histogram.h"
 #include "base/time.h"
@@ skipping 15 matching lines @@
 #include "content/public/browser/notification_details.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/web_contents.h"
 
 using content::NavigationController;
 using content::OpenURLParams;
 using content::Referrer;
 
 namespace {
 
-// User actions on the sync promo (aka "Sign in to Chrome").
+// User actions on the sync promo, i.e., "Sign in to Chrome".
 enum SyncPromoUserFlowActionEnums {
   SYNC_PROMO_VIEWED,
   SYNC_PROMO_LEARN_MORE_CLICKED,
   SYNC_PROMO_ACCOUNT_HELP_CLICKED,
   SYNC_PROMO_CREATE_ACCOUNT_CLICKED,
   SYNC_PROMO_SKIP_CLICKED,
   SYNC_PROMO_SIGN_IN_ATTEMPTED,
   SYNC_PROMO_SIGNED_IN_SUCCESSFULLY,
   SYNC_PROMO_ADVANCED_CLICKED,
   SYNC_PROMO_ENCRYPTION_HELP_CLICKED,
   SYNC_PROMO_CANCELLED_AFTER_SIGN_IN,
   SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN,
   SYNC_PROMO_CLOSED_TAB,
   SYNC_PROMO_CLOSED_WINDOW,
   SYNC_PROMO_LEFT_DURING_THROBBER,
   SYNC_PROMO_BUCKET_BOUNDARY,
   SYNC_PROMO_FIRST_VALID_JS_ACTION = SYNC_PROMO_LEARN_MORE_CLICKED,
   SYNC_PROMO_LAST_VALID_JS_ACTION = SYNC_PROMO_CONFIRMED_AFTER_SIGN_IN,
 };
 
 // This was added because of the need to change the existing UMA enum for the
-// sync promo mid-flight. Ideally these values would be contiguous, but the
-// real world is not always ideal.
+// sync promo mid-flight. Ideally these values would be contiguous, but the real
+// world is not always ideal.
 static bool IsValidUserFlowAction(int action) {
   return (action >= SYNC_PROMO_FIRST_VALID_JS_ACTION &&
           action <= SYNC_PROMO_LAST_VALID_JS_ACTION) ||
          action == SYNC_PROMO_LEFT_DURING_THROBBER;
 }
 
 }  // namespace
 
 SyncPromoHandler::SyncPromoHandler(ProfileManager* profile_manager)
     : SyncSetupHandler(profile_manager),
+      prefs_(NULL),
       window_already_closed_(false) {
 }
 
 SyncPromoHandler::~SyncPromoHandler() {
 }
 
 // static
 void SyncPromoHandler::RegisterUserPrefs(PrefService* prefs) {
   prefs->RegisterIntegerPref(prefs::kSyncPromoViewCount, 0,
       PrefService::UNSYNCABLE_PREF);
@@ skipping 12 matching lines @@
           IsViewSourceMode()) {
     // Listen to see if the tab we're in gets closed.
     registrar_.Add(this, chrome::NOTIFICATION_TAB_CLOSING,
         content::Source<NavigationController>(
             &web_ui()->GetWebContents()->GetController()));
     // Listen to see if the window we're in gets closed.
     registrar_.Add(this, chrome::NOTIFICATION_BROWSER_CLOSING,
         content::NotificationService::AllSources());
   }
 
-  web_ui()->RegisterMessageCallback("SyncPromo:Close",
+  web_ui()->RegisterMessageCallback(
+      "SyncPromo:Close",
       base::Bind(&SyncPromoHandler::HandleCloseSyncPromo,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("SyncPromo:Initialize",
+  web_ui()->RegisterMessageCallback(
+      "SyncPromo:Initialize",
       base::Bind(&SyncPromoHandler::HandleInitializeSyncPromo,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("SyncPromo:RecordSignInAttempts",
+  web_ui()->RegisterMessageCallback(
+      "SyncPromo:RecordSignInAttempts",
       base::Bind(&SyncPromoHandler::HandleRecordSignInAttempts,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("SyncPromo:RecordThrobberTime",
+  web_ui()->RegisterMessageCallback(
+      "SyncPromo:RecordThrobberTime",
       base::Bind(&SyncPromoHandler::HandleRecordThrobberTime,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("SyncPromo:ShowAdvancedSettings",
+  web_ui()->RegisterMessageCallback(
+      "SyncPromo:ShowAdvancedSettings",
       base::Bind(&SyncPromoHandler::HandleShowAdvancedSettings,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("SyncPromo:UserFlowAction",
+  web_ui()->RegisterMessageCallback(
+      "SyncPromo:UserFlowAction",
       base::Bind(&SyncPromoHandler::HandleUserFlowAction,
                  base::Unretained(this)));
-  web_ui()->RegisterMessageCallback("SyncPromo:UserSkipped",
+  web_ui()->RegisterMessageCallback(
+      "SyncPromo:UserSkipped",
       base::Bind(&SyncPromoHandler::HandleUserSkipped,
                  base::Unretained(this)));
   SyncSetupHandler::RegisterMessages();
 }
 
 void SyncPromoHandler::RecordSignin() {
   sync_promo_trial::RecordUserSignedIn(web_ui());
 }
 
 void SyncPromoHandler::DisplayConfigureSync(bool show_advanced,
                                             bool passphrase_failed) {
   ProfileSyncService* service = GetSyncService();
   DCHECK(service);
   if (service->IsPassphraseRequired()) {
     // If a passphrase is required then we must show the configure pane.
     SyncSetupHandler::DisplayConfigureSync(true, passphrase_failed);
   } else {
     // If no passphrase is required then skip the configure pane and sync
-    // everything by default. This makes the first run experience simpler.
-    // Note, there's an advanced link in the sync promo that takes users
-    // to Settings where the configure pane is not skipped.
+    // everything by default. This makes the first run experience simpler. Note,
+    // there's an advanced link in the sync promo that takes users to Settings
+    // where the configure pane is not skipped.
     service->OnUserChoseDatatypes(true, syncable::ModelTypeSet());
     ConfigureSyncDone();
   }
 }
 
 void SyncPromoHandler::Observe(int type,
                                const content::NotificationSource& source,
                                const content::NotificationDetails& details) {
   switch (type) {
     case chrome::NOTIFICATION_TAB_CLOSING: {
@@ skipping 22 matching lines @@
 
 void SyncPromoHandler::HandleCloseSyncPromo(const base::ListValue* args) {
   CloseSyncSetup();
 
   // If the user has signed in then set the pref to show them NTP bubble
   // confirming that they're signed in.
   std::string username = prefs_->GetString(prefs::kGoogleServicesUsername);
   if (!username.empty())
     prefs_->SetBoolean(prefs::kSyncPromoShowNTPBubble, true);
 
-  // If the browser window is being closed then don't try to navigate to
-  // another URL. This prevents the browser window from flashing during
-  // close.
+  // If the browser window is being closed then don't try to navigate to another
+  // URL. This prevents the browser window from flashing during close.
   Browser* browser =
       BrowserList::FindBrowserWithWebContents(web_ui()->GetWebContents());
   if (!browser || !browser->IsAttemptingToCloseBrowser()) {
     GURL url = SyncPromoUI::GetNextPageURLForSyncPromoURL(
         web_ui()->GetWebContents()->GetURL());
     OpenURLParams params(
         url, Referrer(), CURRENT_TAB, content::PAGE_TRANSITION_LINK, false);
     web_ui()->GetWebContents()->OpenURL(params);
   }
 }
@@ skipping 64 matching lines @@
   int adjusted = GetViewCount() + amount;
   prefs_->SetInteger(prefs::kSyncPromoViewCount, adjusted);
   return adjusted;
 }
 
 void SyncPromoHandler::RecordUserFlowAction(int action) {
   // Send an enumeration to our single user flow histogram.
   UMA_HISTOGRAM_ENUMERATION("SyncPromo.UserFlow", action,
                             SYNC_PROMO_BUCKET_BOUNDARY);
 }