Ash/aura split: NativeWidgetAura::GetWindowScreenBounds() should return screen bounds.

Ash/aura split: NativeWidgetAura::GetWindowScreenBounds() should return screen bounds.

- Renames aura::Window::GetScreenBounds() to ::GetBoundsInRootWindow(),
  which is what it really does.
- NativeWidgetAura now gives its NativeWidgetHelperAura a chance to
  modify those bounds.

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133831

[Elliot Glaysher, 2012-04-24 22:06:49]

+sky

[sky, 2012-04-24 22:42:28]

LGTM

http://codereview.chromium.org/10210005/diff/1/ui/aura/window.h
File ui/aura/window.h (right):

http://codereview.chromium.org/10210005/diff/1/ui/aura/window.h#newcode139
ui/aura/window.h:139: // Returns the window's bounds in screen coordinates.
Update the comment. In particular mention this is effectively screen coordinates
for ash, but not for non-ash.

http://codereview.chromium.org/10210005/diff/1/ui/views/widget/desktop_native...
File ui/views/widget/desktop_native_widget_helper_aura.h (right):

http://codereview.chromium.org/10210005/diff/1/ui/views/widget/desktop_native...
ui/views/widget/desktop_native_widget_helper_aura.h:37: gfx::Rect bounds)
OVERRIDE;
const gfx::Rect&

http://codereview.chromium.org/10210005/diff/1/ui/views/widget/native_widget_...
File ui/views/widget/native_widget_helper_aura.h (right):

http://codereview.chromium.org/10210005/diff/1/ui/views/widget/native_widget_...
ui/views/widget/native_widget_helper_aura.h:37: virtual gfx::Rect
ChangeRootWindowBoundsToScreenBounds(gfx::Rect bounds) = 0;
const gfx::Rect&

[oshima, 2012-04-24 23:04:15]

LGTM

http://codereview.chromium.org/10210005/diff/1/ui/aura/root_window.h
File ui/aura/root_window.h (right):

http://codereview.chromium.org/10210005/diff/1/ui/aura/root_window.h#newcode111
ui/aura/root_window.h:111: gfx::Point GetHostOrigin() const;
can this be const gfx::Point& ?

http://codereview.chromium.org/10210005/diff/1/ui/aura/window.h
File ui/aura/window.h (right):

http://codereview.chromium.org/10210005/diff/1/ui/aura/window.h#newcode139
ui/aura/window.h:139: // Returns the window's bounds in screen coordinates.
On 2012/04/24 22:42:28, sky wrote:
> Update the comment. In particular mention this is effectively screen
coordinates
> for ash, but not for non-ash.

Please add TODO(oshima): Fix this to return screen's coordinate for multi
monitor support.

[Elliot Glaysher, 2012-04-24 23:20:18]

http://codereview.chromium.org/10210005/diff/1/ui/aura/root_window.h
File ui/aura/root_window.h (right):

http://codereview.chromium.org/10210005/diff/1/ui/aura/root_window.h#newcode111
ui/aura/root_window.h:111: gfx::Point GetHostOrigin() const;
On 2012/04/24 23:04:15, oshima wrote:
> can this be const gfx::Point& ?

A quick attempt at returning const& here and in GetHostSize() add weird
positioning and segfaults, respectively.

[commit-bot: I haz the power, 2012-04-24 23:22:39]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/erg@chromium.org/10210005/8002

[commit-bot: I haz the power, 2012-04-25 01:12:30]

Change committed as 133831