ash/wm/video_detector.cc - Issue 10210005: Ash/aura split: NativeWidgetAura::GetWindowScreenBounds() should return screen bounds.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/wm/video_detector.cc

Issue 10210005: Ash/aura split: NativeWidgetAura::GetWindowScreenBounds() should return screen bounds. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sky+oshima stuff Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/wm/video_detector.cc

diff --git a/ash/wm/video_detector.cc b/ash/wm/video_detector.cc

index 8ff8105e8190e5e36bb1e2f02dcc0b73b5914b79..07cd4f7a7a7499bdbc0afdebba940b60040e6a4e 100644

--- a/ash/wm/video_detector.cc

+++ b/ash/wm/video_detector.cc

@@ -103,7 +103,7 @@ void VideoDetector::MaybeNotifyObservers(aura::Window* window,

return;

gfx::Rect root_bounds = Shell::GetRootWindow()->bounds();

- if (!window->GetScreenBounds().Intersects(root_bounds))

+ if (!window->GetBoundsInRootWindow().Intersects(root_bounds))

return;

FOR_EACH_OBSERVER(VideoDetectorObserver, observers_, OnVideoDetected());

« no previous file with comments | « ash/tooltips/tooltip_controller.cc ('k') | chrome/browser/tab_contents/chrome_web_contents_view_delegate_views.cc » ('j') | no next file with comments »