Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: site_scons/site_tools/gather_inputs.py

Issue 10210: Bringing in sct changes. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: Created 12 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « site_scons/site_tools/component_targets_msvs.py ('k') | site_scons/site_tools/visual_studio_solution.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: site_scons/site_tools/gather_inputs.py
===================================================================
--- site_scons/site_tools/gather_inputs.py (revision 5002)
+++ site_scons/site_tools/gather_inputs.py (working copy)
@@ -91,13 +91,14 @@
_FindSources(ptrns, lst, all)
return
+ # Get real file (backed by repositories).
+ rfile = tgt.rfile()
+ rfile_is_file = rfile.isfile()
# See who it matches
for pattern, lst in ptrns.items():
- # Get real file (backed by repositories).
- rfile = tgt.rfile()
# Add files to the list for the first pattern that matches (implicitly,
# don't add directories).
- if rfile.isfile() and pattern.match(rfile.path):
+ if rfile_is_file and pattern.match(rfile.path):
lst.append(rfile.abspath)
break
« no previous file with comments | « site_scons/site_tools/component_targets_msvs.py ('k') | site_scons/site_tools/visual_studio_solution.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698