Bringing in sct changes.

site_scons/site_tools/gather_inputs.py

 #!/usr/bin/python2.4
 # Copyright 2008, Google Inc.
 # All rights reserved.
 #
 # Redistribution and use in source and binary forms, with or without
 # modification, are permitted provided that the following conditions are
 # met:
 #
 #     * Redistributions of source code must retain the above copyright
 # notice, this list of conditions and the following disclaimer.
@@ skipping 73 matching lines @@
       if (exclude_pattern and target_abspath
           and exclude_pattern.match(target_abspath)):
         return
 
       # Handle non-leaf nodes recursively
       lst = tgt.children(scan=1)
       if lst:
         _FindSources(ptrns, lst, all)
         return
 
+      # Get real file (backed by repositories).
+      rfile = tgt.rfile()
+      rfile_is_file = rfile.isfile()
       # See who it matches
       for pattern, lst in ptrns.items():
-        # Get real file (backed by repositories).
-        rfile = tgt.rfile()
         # Add files to the list for the first pattern that matches (implicitly,
         # don't add directories).
-        if rfile.isfile() and pattern.match(rfile.path):
+        if rfile_is_file and pattern.match(rfile.path):
           lst.append(rfile.abspath)
           break
 
   # Prepare a group for each pattern.
   patterns = {}
   for g in groups:
     patterns[re.compile(g, re.IGNORECASE)] = []
 
   # Do the search.
   _FindSources(patterns, target, {})
 
   return patterns.values()
 
 
 def generate(env):
   # NOTE: SCons requires the use of this name, which fails gpylint.
   """SCons entry point for this tool."""
 
   # Add a method to gather all inputs needed by a target.
   env.AddMethod(GatherInputs, 'GatherInputs')