Add key modifier to minimize/restore button click to minimize/restore-all panels for GTK

Add key modifier to minimize/restore button click to minimize/restore-all panels for GTK

BUG=123176
TEST=existing tests


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134579

[jianli, 2012-04-27 23:12:17]

Evan, could you please review one-line change to make Init() vritual in
BrowserTitlebar?

Jenn, could you please all other changes?

[jennb, 2012-04-27 23:38:39]

http://codereview.chromium.org/10209037/diff/1/chrome/browser/ui/panels/panel...
File chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc (right):

http://codereview.chromium.org/10209037/diff/1/chrome/browser/ui/panels/panel...
chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc:32: void
PanelBrowserTitlebarGtk::Init() {
Don't need to override Init() in titlebar. You can have
PanelBrowserWindowGtk::Init() call this titlebar class directly to connect
signals after the window has connected its signals.

[jennb, 2012-04-27 23:43:15]

http://codereview.chromium.org/10209037/diff/1/chrome/browser/ui/panels/panel...
File chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc (right):

http://codereview.chromium.org/10209037/diff/1/chrome/browser/ui/panels/panel...
chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc:37: if (minimize_button()
&& unminimize_button_.get()) {
Or, since we connect signals in the PanelBrowserWindowGtk, just connect the
signals in that file instead so that we consistently have all signal handlers
for titlebar things in the window. Seems weird to watch titlebar click in that
file and button clicks here in this file.

[jennb, 2012-04-28 03:28:16]

Jian - you don't need to register a signal for mouse-release. Use the clicked
signal. In HandleButtonClick, you can use gtk_get_current_event() to access the
event.

http://developer.gnome.org/gtk/2.24/gtk-General.html#gtk-get-current-event

[jianli, 2012-04-30 17:40:35]

Changed to use gtk_get_current_event, as suggested. Since I don't need to change
BrowserTitlebar, I do not need the approval from Evan.

[jennb, 2012-04-30 18:06:42]

lgtm

[commit-bot: I haz the power, 2012-04-30 18:32:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jianli@chromium.org/10209037/6003

[commit-bot: I haz the power, 2012-04-30 20:08:50]

Change committed as 134579