Add key modifier to minimize/restore button click to minimize/restore-all panels for GTK

chrome/browser/ui/panels/panel_browser_titlebar_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/panels/panel_browser_titlebar_gtk.h"
 
 #include "chrome/browser/ui/gtk/custom_button.h"
 #include "chrome/browser/ui/panels/panel.h"
 #include "chrome/browser/ui/panels/panel_browser_window_gtk.h"
 #include "grit/generated_resources.h"
@@ skipping 11 matching lines @@
 
 PanelBrowserTitlebarGtk::PanelBrowserTitlebarGtk(
     PanelBrowserWindowGtk* browser_window, GtkWindow* window)
     : BrowserTitlebar(browser_window, window),
       browser_window_(browser_window) {
 }
 
 PanelBrowserTitlebarGtk::~PanelBrowserTitlebarGtk() {
 }
 
+void PanelBrowserTitlebarGtk::Init() {

[jennb, 2012/04/27 23:38:39]

Don't need to override Init() in titlebar. You can have
PanelBrowserWindowGtk::Init() call this titlebar class directly to connect
signals after the window has connected its signals.

+  BrowserTitlebar::Init();
+
+  // Need to watch for minimize/unminimize button release event so that we can
+  // find out if the user is pressing down the modifier key simultaneously.
+  if (minimize_button() && unminimize_button_.get()) {

[jennb, 2012/04/27 23:43:15]

Or, since we connect signals in the PanelBrowserWindowGtk, just connect the
signals in that file instead so that we consistently have all signal handlers
for titlebar things in the window. Seems weird to watch titlebar click in that
file and button clicks here in this file.

+    g_signal_connect(minimize_button()->widget(), "button-release-event",
+                     G_CALLBACK(OnMinimizeButtonReleaseEventThunk), this);
+    g_signal_connect(unminimize_button_->widget(), "button-release-event",
+                     G_CALLBACK(OnUnminimizeButtonReleaseEventThunk), this);
+  }
+}
+
 bool PanelBrowserTitlebarGtk::BuildButton(const std::string& button_token,
                                           bool left_side) {
   // Panel only shows close and minimize/restore buttons.
   if (button_token != "close" && button_token != "minimize")
     return false;
 
   // Create unminimze button in order to show it to expand the minimized panel.
   if (button_token == "minimize")
     unminimize_button_.reset(CreateTitlebarButton("unminimize", left_side));
 
@@ skipping 36 matching lines @@
     return;
 
   Panel* panel = browser_window_->panel();
   gtk_widget_set_visible(minimize_button()->widget(), panel->CanMinimize());
   gtk_widget_set_visible(unminimize_button_->widget(), panel->CanRestore());
 }
 
 void PanelBrowserTitlebarGtk::HandleButtonClick(GtkWidget* button) {
   if (close_button() && close_button()->widget() == button)
     browser_window_->panel()->Close();
-  else if (minimize_button() && minimize_button()->widget() == button)
-    browser_window_->panel()->Minimize();
-  else if (unminimize_button_.get() && unminimize_button_->widget() == button)
-    browser_window_->panel()->Restore();
+  // Minimize/unminimize buttons are handled in mouse-release-event so that we
+  // can find out if the user is pressing down the modifier key simultaneously.
 }
 
 void PanelBrowserTitlebarGtk::ShowFaviconMenu(GdkEventButton* event) {
   // Favicon menu is not supported in panels.
 }
+
+gboolean PanelBrowserTitlebarGtk::OnMinimizeButtonReleaseEvent(
+    GtkWidget* widget, GdkEventButton* event) {
+  if (event->button != 1)
+    return TRUE;
+
+  browser_window_->panel()->OnMinimizeButtonClicked(
+      (event->state & GDK_CONTROL_MASK) ?
+          panel::APPLY_TO_ALL : panel::NO_MODIFIER);
+  return TRUE;
+}
+
+gboolean PanelBrowserTitlebarGtk::OnUnminimizeButtonReleaseEvent(
+    GtkWidget* widget, GdkEventButton* event) {
+  if (event->button != 1)
+    return TRUE;
+
+  browser_window_->panel()->OnRestoreButtonClicked(
+      (event->state & GDK_CONTROL_MASK) ?
+          panel::APPLY_TO_ALL : panel::NO_MODIFIER);
+  return TRUE;
+}