Remove an unused #include of a native_client header

Remove an unused #include of a native_client header

BUG=none
TEST=build


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134179

[jam, 2012-04-25 02:33:57]

I'm confused how checkdeps passed, since src/include_rules doesn't have
native_client in it?

[Mark Seaborn, 2012-04-25 17:28:22]

On 24 April 2012 19:33, <jam@chromium.org> wrote:

> I'm confused how checkdeps passed, since src/include_rules doesn't have
> native_client in it?
>

"native_client" doesn't have to be in DEPS's "include_rules" to be
allowed.  Being in DEPS's "deps" list is enough.  So, if I comment out the
"src/native_client" entry in "deps", checkdeps starts rejecting a lot of
#includes.

Mark

[jam, 2012-04-26 20:03:03]

if that's the case, that's a bug in checkdeps and we should fix that script
instead.

[Mark Seaborn, 2012-04-26 20:08:20]

On 26 April 2012 13:03, <jam@chromium.org> wrote:

> if that's the case, that's a bug in checkdeps and we should fix that script
> instead.
>

Surely "as well", not "instead"?  If checkdeps were changed, we would still
need to remove the unused #include that this change removes.

Mark

[jam, 2012-04-26 20:19:05]

On 2012/04/26 20:08:20, Mark Seaborn wrote:
> On 26 April 2012 13:03, <mailto:jam@chromium.org> wrote:
> 
> > if that's the case, that's a bug in checkdeps and we should fix that script
> > instead.
> >
> 
> Surely "as well", not "instead"?  If checkdeps were changed, we would still
> need to remove the unused #include that this change removes.
> 
> Mark

yeah, sorry I should have been clearer. the render_process_impl.h is fine, but i
meant instead of the content/DEPS change

[Mark Seaborn, 2012-04-26 21:46:40]

On 26 April 2012 13:19, <jam@chromium.org> wrote:

> On 2012/04/26 20:08:20, Mark Seaborn wrote:
>
>  On 26 April 2012 13:03, <mailto:jam@chromium.org> wrote:
>>
>
>  > if that's the case, that's a bug in checkdeps and we should fix that
>> script
>> > instead.
>> >
>>
>
>  Surely "as well", not "instead"?  If checkdeps were changed, we would
>> still
>> need to remove the unused #include that this change removes.
>>
>
>  Mark
>>
>
> yeah, sorry I should have been clearer. the render_process_impl.h is fine,
> but i
> meant instead of the content/DEPS change
>

OK, I agree that checkdeps' behaviour of whitelisting everything in 'deps'
seems undesirable, but it does seem to be explicitly intended (it
specifically looks at DEPS_VAR_NAME).  Do you want to file a bug?  I don't
know checkdeps well enough to know whether it should be changed.

I've undone the content/DEPS change, so is the one-liner OK to commit?

Mark

[jam, 2012-04-26 22:03:00]

lgtm

[commit-bot: I haz the power, 2012-04-26 22:03:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mseaborn@chromium.org/10207027/14001

[commit-bot: I haz the power, 2012-04-27 00:13:06]

Change committed as 134179