Issue 10207001: Clean up a raft of SPDY files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10207001: Clean up a raft of SPDY files (Closed)

Created:
8 years, 8 months ago by Ryan Hamilton

Modified:
8 years, 8 months ago

Reviewers:
ramant (doing other things)

CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Clean up a raft of SPDY files to bring in sync with server Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133791

Patch Set 2 : A few more fixes #

Patch Set 3 : no ssize_t :( #

Total comments: 1

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+143 lines, -162 lines)			Patch
M	net/spdy/spdy_frame_reader_test.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/spdy/spdy_framer.cc	View	1 2	19 chunks	+19 lines, -23 lines	0 comments	Download
M	net/spdy/spdy_framer_test.cc	View	1	70 chunks	+117 lines, -128 lines	1 comment	Download
M	net/spdy/spdy_protocol_test.cc	View		3 chunks	+5 lines, -9 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

Just FYI, I've fixed the ssize_t issue and the CL works on windows. (The try ...

8 years, 8 months ago (2012-04-24 20:29:05 UTC) #2

ramant (doing other things)

lgtm https://chromiumcodereview.appspot.com/10207001/diff/9001/net/spdy/spdy_framer_test.cc File net/spdy/spdy_framer_test.cc (right): https://chromiumcodereview.appspot.com/10207001/diff/9001/net/spdy/spdy_framer_test.cc#newcode47 net/spdy/spdy_framer_test.cc:47: // the SpdyFramer. The implemention is meant for ...

8 years, 8 months ago (2012-04-24 20:53:37 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/10207001/9001

8 years, 8 months ago (2012-04-24 21:07:28 UTC) #4

Change committed as 133791