net/spdy/spdy_frame_reader_test.cc - Issue 10207001: Clean up a raft of SPDY files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/spdy/spdy_frame_reader_test.cc

Issue 10207001: Clean up a raft of SPDY files (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: no ssize_t :( Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/spdy/spdy_frame_reader_test.cc

diff --git a/net/spdy/spdy_frame_reader_test.cc b/net/spdy/spdy_frame_reader_test.cc

index fda2fce0b6c4df860e655568c3366e774b07fe4e..c72e5bebac066b39e771f46c1641b9192e5bcfb8 100644

--- a/net/spdy/spdy_frame_reader_test.cc

+++ b/net/spdy/spdy_frame_reader_test.cc

@@ -25,7 +25,7 @@ TEST(SpdyFrameReaderTest, ReadUInt16) {

uint16 uint16_val;

EXPECT_TRUE(frame_reader.ReadUInt16(&uint16_val));

EXPECT_FALSE(frame_reader.IsDoneReading());

- EXPECT_EQ(1u, uint16_val);

+ EXPECT_EQ(1, uint16_val);

EXPECT_TRUE(frame_reader.ReadUInt16(&uint16_val));

EXPECT_TRUE(frame_reader.IsDoneReading());

@@ -49,7 +49,7 @@ TEST(SpdyFrameReaderTest, ReadUInt32) {

EXPECT_TRUE(frame_reader.ReadUInt32(&uint32_val));

EXPECT_TRUE(frame_reader.IsDoneReading());

- EXPECT_EQ(static_cast<uint32>(1<<31), uint32_val);

+ EXPECT_EQ(1u<<31, uint32_val);

}

TEST(SpdyFrameReaderTest, ReadStringPiece16) {

« no previous file with comments | « no previous file | net/spdy/spdy_framer.cc » ('j') | net/spdy/spdy_framer_test.cc » ('J')