Move TranslateInfoBarUtilities to a common place so that other infobars may reuse these helpers

Move TranslateInfoBarUtilities to a common place so that other infobars may reuse these helpers

BUG=NONE
TEST=NONE


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=134493

[Jeremy Mao, 2012-04-27 12:02:27]

Hi sky, shess,

Could you please take a look at this when you are free?

Since these helper function can be reused by other infobars, like media stream
infobar etc. Move them out of translate_infobar_base.h, also fix a style issue.

Thanks & Best regards
Jeremy

[Avi (use Gerrit), 2012-04-28 16:55:37]

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
File chrome/browser/ui/cocoa/infobars/infobar_utilities.h (right):

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
chrome/browser/ui/cocoa/infobars/infobar_utilities.h:11: #pragma mark
InfoBarUtilities helper functions.
1) We don't use pragmas. Use comments.
2) This is not a useful comment. Comment _why_ not _what_.

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
chrome/browser/ui/cocoa/infobars/infobar_utilities.h:23: // Also, check that
there is space between them.
Combine with line above.

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
File chrome/browser/ui/cocoa/infobars/infobar_utilities.mm (right):

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
chrome/browser/ui/cocoa/infobars/infobar_utilities.mm:1: // Copyright (c) 2011
The Chromium Authors. All rights reserved.
year

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
chrome/browser/ui/cocoa/infobars/infobar_utilities.mm:10: #pragma mark
TranslateInfoBarUtilities helper functions.
Useless; remove.

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
chrome/browser/ui/cocoa/infobars/infobar_utilities.mm:77: keyEquivalent:@""]
autorelease];
scoped_nsobject instead.

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
File chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm (right):

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm:6: 
You sure we don't need this any more?

http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm:33:
TranslateInfoBarControllerBase* infobarController = NULL;
No. Variable styles are set by the type of code they're in. This is a C++
function, therefore it gets C++ naming of variables.

[Jeremy Mao, 2012-04-29 02:22:19]

On 2012/04/28 16:55:37, Avi wrote:
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> File chrome/browser/ui/cocoa/infobars/infobar_utilities.h (right):
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> chrome/browser/ui/cocoa/infobars/infobar_utilities.h:11: #pragma mark
> InfoBarUtilities helper functions.
> 1) We don't use pragmas. Use comments.
> 2) This is not a useful comment. Comment _why_ not _what_.
Done.
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> chrome/browser/ui/cocoa/infobars/infobar_utilities.h:23: // Also, check that
> there is space between them.
> Combine with line above.
Done.
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> File chrome/browser/ui/cocoa/infobars/infobar_utilities.mm (right):
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> chrome/browser/ui/cocoa/infobars/infobar_utilities.mm:1: // Copyright (c) 2011
> The Chromium Authors. All rights reserved.
> year
Done.
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> chrome/browser/ui/cocoa/infobars/infobar_utilities.mm:10: #pragma mark
> TranslateInfoBarUtilities helper functions.
> Useless; remove.
Done.
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> chrome/browser/ui/cocoa/infobars/infobar_utilities.mm:77: keyEquivalent:@""]
> autorelease];
> scoped_nsobject instead.
Done.
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> File chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm (right):
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm:6: 
> You sure we don't need this any more?
.h file already have one.
> 
>
http://codereview.chromium.org/10206024/diff/1/chrome/browser/ui/cocoa/infoba...
> chrome/browser/ui/cocoa/infobars/translate_infobar_base.mm:33:
> TranslateInfoBarControllerBase* infobarController = NULL;
> No. Variable styles are set by the type of code they're in. This is a C++
> function, therefore it gets C++ naming of variables.
Done.

[Avi (use Gerrit), 2012-04-29 02:25:52]

lgtm

[commit-bot: I haz the power, 2012-04-29 07:31:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/yujie.mao@intel.com/10206024/6003

[Jeremy Mao, 2012-04-29 12:36:23]

On 2012/04/29 02:25:52, Avi wrote:
> lgtm

Hi avi,

Could you help me commit this change? It seems CQ get stuck.

Thanks & Best regards
Jeremy

[commit-bot: I haz the power, 2012-04-29 12:57:58]

Change committed as 134493