Move TranslateInfoBarUtilities to a common place so that other infobars may reuse these helpers

chrome/browser/ui/cocoa/infobars/infobar_utilities.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_UI_COCOA_INFOBARS_INFOBAR_UTILITIES_H_
+#define CHROME_BROWSER_UI_COCOA_INFOBARS_INFOBAR_UTILITIES_H_
+#pragma once
+
+#import <Cocoa/Cocoa.h>
+
+#pragma mark InfoBarUtilities helper functions.

[Avi (use Gerrit), 2012/04/28 16:55:37]

1) We don't use pragmas. Use comments.
2) This is not a useful comment. Comment _why_ not _what_.

+namespace InfoBarUtilities {
+
+// Move the |toMove| view |spacing| pixels before/after the |anchor| view.
+// |after| signifies the side of |anchor| on which to place |toMove|.
+void MoveControl(NSView* anchor, NSView* toMove, int spacing, bool after);
+
+// Vertically center |toMove| in its container.
+void VerticallyCenterView(NSView *toMove);
+
+// Check that the control |before| is ordered visually before the |after|
+// control.
+// Also, check that there is space between them.

[Avi (use Gerrit), 2012/04/28 16:55:37]

Combine with line above.

+bool VerifyControlOrderAndSpacing(id before, id after);
+
+// Creates a label control in the style we need for the infobar's labels
+// within |bounds|.
+NSTextField* CreateLabel(NSRect bounds);
+
+// Adds an item with the specified properties to |menu|.
+void AddMenuItem(NSMenu *menu, id target, SEL selector, NSString* title,
+    int tag, bool enabled, bool checked);
+
+}  // namespace InfoBarUtilities
+
+#endif  // CHROME_BROWSER_UI_COCOA_INFOBARS_INFOBAR_UTILITIES_H_