Refactoring StreamParser & StreamParserHost interfaces.

media/base/stream_parser.h

Index: media/base/stream_parser.h
diff --git a/media/base/stream_parser.h b/media/base/stream_parser.h
index 8397fad1177cc58b0c2b45354f755ce7f0b46f88..b64b42584549e1ac3a363041ce85a070fa5dbb21 100644
--- a/media/base/stream_parser.h
+++ b/media/base/stream_parser.h
@@ -27,13 +27,11 @@ class MEDIA_EXPORT StreamParserHost {
   StreamParserHost();
   virtual ~StreamParserHost();
 
-  // A new audio decoder configuration was encountered. All audio buffers
-  // after this call will be associated with this configuration.
-  virtual bool OnNewAudioConfig(const AudioDecoderConfig& config) = 0;
-
-  // A new video decoder configuration was encountered. All video buffers
-  // after this call will be associated with this configuration.
-  virtual bool OnNewVideoConfig(const VideoDecoderConfig& config) = 0;
+  // New audio and/or video decoder configurations were encountered. All audio
+  // and video buffers after this call will be associated with these
+  // configurations.
+  virtual bool OnNewConfigs(const AudioDecoderConfig& audio_config,

[scherkus (not reviewing), 2012/04/24 01:40:04]

what does true/false mean?

[acolwell GONE FROM CHROMIUM, 2012/04/24 16:25:55]

Done.

+                            const VideoDecoderConfig& video_config) = 0;
 
   // New audio buffers have been received.
   virtual bool OnAudioBuffers(const BufferQueue& buffers) = 0;
@@ -72,10 +70,8 @@ class MEDIA_EXPORT StreamParser {
 
   // Called when there is new data to parse.
   //
-  // Returns < 0 if the parse fails.
-  // Returns 0 if more data is needed.
-  // Returning > 0 indicates success & the number of bytes parsed.
-  virtual int Parse(const uint8* buf, int size) = 0;
+  // Returns true if the parse succeeds.
+  virtual bool Parse(const uint8* buf, int size) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(StreamParser);