Refactoring StreamParser & StreamParserHost interfaces.

media/base/stream_parser.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_STREAM_PARSER_H_
 #define MEDIA_BASE_STREAM_PARSER_H_
 
 #include <deque>
 
 #include "base/callback_forward.h"
 #include "base/memory/ref_counted.h"
 #include "base/time.h"
 #include "media/base/media_export.h"
 
 namespace media {
 
 class AudioDecoderConfig;
 class Buffer;
 class VideoDecoderConfig;
 
 // Provides callback methods for StreamParser to report information
 // about the media stream.
 class MEDIA_EXPORT StreamParserHost {
  public:
   typedef std::deque<scoped_refptr<Buffer> > BufferQueue;
 
   StreamParserHost();
   virtual ~StreamParserHost();
 
-  // A new audio decoder configuration was encountered. All audio buffers
-  // after this call will be associated with this configuration.
-  virtual bool OnNewAudioConfig(const AudioDecoderConfig& config) = 0;
-
-  // A new video decoder configuration was encountered. All video buffers
-  // after this call will be associated with this configuration.
-  virtual bool OnNewVideoConfig(const VideoDecoderConfig& config) = 0;
+  // New audio and/or video decoder configurations were encountered. All audio
+  // and video buffers after this call will be associated with these
+  // configurations.
+  virtual bool OnNewConfigs(const AudioDecoderConfig& audio_config,

[scherkus (not reviewing), 2012/04/24 01:40:04]

what does true/false mean?

[acolwell GONE FROM CHROMIUM, 2012/04/24 16:25:55]

Done.

+                            const VideoDecoderConfig& video_config) = 0;
 
   // New audio buffers have been received.
   virtual bool OnAudioBuffers(const BufferQueue& buffers) = 0;
 
   // New video buffers have been received.
   virtual bool OnVideoBuffers(const BufferQueue& buffers) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(StreamParserHost);
 };
@@ skipping 18 matching lines @@
   // start time, and duration.
   virtual void Init(const InitCB& init_cb, StreamParserHost* host) = 0;
 
   // Called when a seek occurs. This flushes the current parser state
   // and puts the parser in a state where it can receive data for the new seek
   // point.
   virtual void Flush() = 0;
 
   // Called when there is new data to parse.
   //
-  // Returns < 0 if the parse fails.
-  // Returns 0 if more data is needed.
-  // Returning > 0 indicates success & the number of bytes parsed.
-  virtual int Parse(const uint8* buf, int size) = 0;
+  // Returns true if the parse succeeds.
+  virtual bool Parse(const uint8* buf, int size) = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(StreamParser);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_STREAM_PARSER_H_