no virtual destructor for point/size/rect

Noone should use base class, so it's safe to remove virtual destructors for point/size/rect

BUG=none
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133795

[jbates, 2012-04-24 16:21:05]

LGTM, thanks.

[oshima, 2012-04-24 16:41:55]

+sky for OWNERS review

[sky, 2012-04-24 17:41:14]

http://codereview.chromium.org/10203004/diff/1/ui/gfx/point.h
File ui/gfx/point.h (right):

http://codereview.chromium.org/10203004/diff/1/ui/gfx/point.h#newcode37
ui/gfx/point.h:37: ~Point() {}
Move the destructors to be protected so we know no one is trying to delete
through the base classes.

[jbates, 2012-04-24 17:44:47]

http://codereview.chromium.org/10203004/diff/1/ui/gfx/point.h
File ui/gfx/point.h (right):

http://codereview.chromium.org/10203004/diff/1/ui/gfx/point.h#newcode37
ui/gfx/point.h:37: ~Point() {}
On 2012/04/24 17:41:14, sky wrote:
> Move the destructors to be protected so we know no one is trying to delete
> through the base classes.

The PointBase destructor is protected. Might be helpful to have some comments to
explain that it's not allowed to derive from Point though.

[oshima, 2012-04-24 17:54:10]

http://codereview.chromium.org/10203004/diff/1/ui/gfx/point.h
File ui/gfx/point.h (right):

http://codereview.chromium.org/10203004/diff/1/ui/gfx/point.h#newcode37
ui/gfx/point.h:37: ~Point() {}
Yes, this dtor needs to be still public. All base classes' dtor are protected.
I added comment to make it clear.

On 2012/04/24 17:44:47, jbates wrote:
> On 2012/04/24 17:41:14, sky wrote:
> > Move the destructors to be protected so we know no one is trying to delete
> > through the base classes.
> 
> The PointBase destructor is protected. Might be helpful to have some comments
to
> explain that it's not allowed to derive from Point though.

[sky, 2012-04-24 19:38:42]

LGTM

Make sure you run through clang, it might be unhappy.

[oshima, 2012-04-24 21:11:00]

On 2012/04/24 19:38:42, sky wrote:
> LGTM
> 
> Make sure you run through clang, it might be unhappy.

linux_clang was happy, and there should be no difference on linux_chromeos for
this change.

[commit-bot: I haz the power, 2012-04-24 21:11:21]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/10203004/11001

[commit-bot: I haz the power, 2012-04-24 22:56:10]

Change committed as 133795