ui/gfx/rect_base.h - Issue 10203004: no virtual destructor for point/size/rect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/gfx/rect_base.h

Issue 10203004: no virtual destructor for point/size/rect (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: added comment Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/gfx/rect_base.h

diff --git a/ui/gfx/rect_base.h b/ui/gfx/rect_base.h

index 3ccd28de754088fcee87159cfdbdbfb80153b755..3a273fe2da367eb6298e4993ce7ebfc48f026b72 100644

--- a/ui/gfx/rect_base.h

+++ b/ui/gfx/rect_base.h

@@ -140,7 +140,9 @@ class UI_EXPORT RectBase {

RectBase(const PointClass& origin, const SizeClass& size);

explicit RectBase(const SizeClass& size);

explicit RectBase(const PointClass& origin);

- virtual ~RectBase();

+ // Destructor is intentionally made non virtual and protected.

+ // Do not make this public.

+ ~RectBase();

private:

PointClass origin_;

« no previous file with comments | « ui/gfx/rect.h ('k') | ui/gfx/rect_f.h » ('j') | no next file with comments »