Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 10202008: Add EncodeRGBAPNGWithChecksum method. (Closed)

Created:
8 years, 8 months ago by Johnny(Jianning) Ding
Modified:
8 years, 8 months ago
Reviewers:
tkent, tony
CC:
chromium-reviews, darin-cc_chromium.org
Visibility:
Public.

Description

Add EncodeRGBAPNGWithChecksum method. Adding this method is to dump image for DRT on Chromium Android port. See https://bugs.webkit.org/show_bug.cgi?id=84682 for details. NOTE. Skia pixel layout definition is in <chrome-source-root>/third_party/skia/include/core/SkPostConfig.h for Chromium Android platform. <chrome-source-root>/skia/config/SkUserConfig.h for other Chromium platforms. BUG=None. TEST=should not affect any tests. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133861

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -0 lines) Patch
M webkit/support/webkit_support_gfx.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M webkit/support/webkit_support_gfx.cc View 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Johnny(Jianning) Ding
8 years, 8 months ago (2012-04-24 09:27:42 UTC) #1
Johnny(Jianning) Ding
On 2012/04/24 09:27:42, Johnny(Jianning) Ding wrote: Just found it's unnecessary to add the method. Close ...
8 years, 8 months ago (2012-04-24 16:06:45 UTC) #2
Johnny(Jianning) Ding
On 2012/04/24 16:06:45, Johnny(Jianning) Ding wrote: > On 2012/04/24 09:27:42, Johnny(Jianning) Ding wrote: > > ...
8 years, 8 months ago (2012-04-24 16:13:36 UTC) #3
Johnny(Jianning) Ding
On 2012/04/24 16:13:36, Johnny(Jianning) Ding wrote: > On 2012/04/24 16:06:45, Johnny(Jianning) Ding wrote: > > ...
8 years, 8 months ago (2012-04-25 02:37:51 UTC) #4
tkent
LGTM
8 years, 8 months ago (2012-04-25 03:02:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jnd@chromium.org/10202008/6001
8 years, 8 months ago (2012-04-25 03:18:57 UTC) #6
commit-bot: I haz the power
8 years, 8 months ago (2012-04-25 04:46:25 UTC) #7
Change committed as 133861

Powered by Google App Engine
This is Rietveld 408576698