Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc

Issue 10201016: Conflict detection for Extension Keybinding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressed comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc (revision 134889)
+++ chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc (working copy)
@@ -14,6 +14,8 @@
#include "base/message_loop.h"
#include "base/utf_string_conversions.h"
#include "chrome/browser/extensions/extension_browser_event_router.h"
+#include "chrome/browser/extensions/extension_command_service.h"
+#include "chrome/browser/extensions/extension_command_service_factory.h"
#include "chrome/browser/extensions/extension_context_menu_model.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/extensions/image_loading_tracker.h"
@@ -365,8 +367,11 @@
// Connect the accelerator for the browser action popup.
void ConnectBrowserActionPopupAccelerator() {
+ ExtensionCommandService* command_service =
+ ExtensionCommandServiceFactory::GetForProfile(
+ toolbar_->browser()->profile());
const Extension::ExtensionKeybinding* command =
- extension_->browser_action_command();
+ command_service->GetActiveBrowserActionCommand(extension_->id());
if (command) {
// Found the browser action shortcut command, register it.
keybinding_.reset(new ui::AcceleratorGtk(

Powered by Google App Engine
This is Rietveld 408576698