Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(659)

Unified Diff: chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc

Issue 10201016: Conflict detection for Extension Keybinding. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Addressed comments Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc
===================================================================
--- chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc (revision 134889)
+++ chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.cc (working copy)
@@ -5,6 +5,8 @@
#include "chrome/browser/ui/gtk/extensions/extension_keybinding_registry_gtk.h"
#include "chrome/browser/extensions/extension_browser_event_router.h"
+#include "chrome/browser/extensions/extension_command_service.h"
+#include "chrome/browser/extensions/extension_command_service_factory.h"
#include "chrome/browser/extensions/extension_service.h"
#include "chrome/browser/profiles/profile.h"
#include "chrome/common/extensions/extension.h"
@@ -42,9 +44,12 @@
void ExtensionKeybindingRegistryGtk::AddExtensionKeybinding(
const Extension* extension) {
- // Add all the keybindings (except pageAction and browserAction, which are
- // handled elsewhere).
- const Extension::CommandMap& commands = extension->named_commands();
+ // Add all the active keybindings (except page actions and browser actions,
+ // which are handled elsewhere).
+ ExtensionCommandService* command_service =
+ ExtensionCommandServiceFactory::GetForProfile(profile_);
+ const Extension::CommandMap& commands =
+ command_service->GetActiveNamedCommands(extension->id());
Extension::CommandMap::const_iterator iter = commands.begin();
for (; iter != commands.end(); ++iter) {
ui::AcceleratorGtk accelerator(iter->second.accelerator().key_code(),
« no previous file with comments | « chrome/browser/ui/gtk/browser_actions_toolbar_gtk.cc ('k') | chrome/browser/ui/gtk/location_bar_view_gtk.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698