Switch chrome and chromiumDRT over to using the new WebKit API for dispatching events.

Switch chrome and chromiumDRT over to using the new WebKit API for dispatching
events into webkit/webcore. This also includes informing DomStorageContext
EventObservers of session storage mutations too since we're switching to handling
them in the same way as local storage events.

Note: This is patch 2 of a multi-sided affair. The new event handling won't be fully
turned on until patch 3 on the webkit side. Here's patch 1...
https://bugs.webkit.org/show_bug.cgi?id=84387


BUG=94382
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=134037

[michaeln, 2012-04-24 23:29:08]

another one

[ericu, 2012-04-25 19:40:34]

LGTM

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
File content/renderer/render_thread_impl.cc (right):

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
content/renderer/render_thread_impl.cc:838: // can span process boundaries, so
there are correctness issues here.
Should be a TODO to make it more obvious.

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
File content/renderer/renderer_webstoragenamespace_impl.cc (left):

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
content/renderer/renderer_webstoragenamespace_impl.cc:30: // Ideally, we'd keep
a hash map of origin to these objects.  Unfortunately
Is this comment obsolete?  Or is it just that it's true enough that it's
pointless to have it?

[michaeln, 2012-04-25 20:22:11]

thnx!

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
File content/renderer/render_thread_impl.cc (right):

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
content/renderer/render_thread_impl.cc:838: // can span process boundaries, so
there are correctness issues here.
On 2012/04/25 19:40:35, ericu wrote:
> Should be a TODO to make it more obvious.

Done

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
File content/renderer/renderer_webstoragenamespace_impl.cc (left):

https://chromiumcodereview.appspot.com/10201010/diff/3007/content/renderer/re...
content/renderer/renderer_webstoragenamespace_impl.cc:30: // Ideally, we'd keep
a hash map of origin to these objects.  Unfortunately
On 2012/04/25 19:40:35, ericu wrote:
> Is this comment obsolete?  Or is it just that it's true enough that it's
> pointless to have it?

Yes and yes.

Obsolete. I think it would be counter productive to share a ptr to the same area
instance for different consumers. If we did so, there's be no way to identify
the Document associated with an area instance and it would make targetting the
events more difficult.

And the comment was kind of not-so-useful chit-chatty anyway even if it would
have been an improvement to refcount these interface ptrs.

[michaeln, 2012-04-25 21:38:59]

@jam, care to do a content owner review?

[jam, 2012-04-26 01:03:56]

lgtm

http://codereview.chromium.org/10201010/diff/28001/content/browser/dom_storag...
File content/browser/dom_storage/dom_storage_message_filter.cc (right):

http://codereview.chromium.org/10201010/diff/28001/content/browser/dom_storag...
content/browser/dom_storage/dom_storage_message_filter.cc:241: DCHECK(area);
nit: this is redundant since if it's null a crash two lines down will be just as
helpful

[michaeln, 2012-04-26 01:20:38]

https://chromiumcodereview.appspot.com/10201010/diff/28001/content/browser/do...
File content/browser/dom_storage/dom_storage_message_filter.cc (right):

https://chromiumcodereview.appspot.com/10201010/diff/28001/content/browser/do...
content/browser/dom_storage/dom_storage_message_filter.cc:241: DCHECK(area);
On 2012/04/26 01:03:56, John Abd-El-Malek wrote:
> nit: this is redundant since if it's null a crash two lines down will be just
as
> helpful

Done.