Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(599)

Issue 10199016: Add disabled_warnings arg to RunPylint() and use the default pylintrc file by default. (Closed)

Created:
8 years, 8 months ago by M-A Ruel
Modified:
8 years, 8 months ago
Reviewers:
cmp
CC:
chromium-reviews, Dirk Pranke, M-A Ruel, Lei Zhang
Visibility:
Public.

Description

Add disabled_warnings arg to RunPylint() and use the default pylintrc file by default. Update pylintrc to be near the pylint 0.25.1 default file. R=cmp@chromium.org BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133707

Patch Set 1 #

Patch Set 2 : Add hashlib to the ignored symbols by pylint #

Unified diffs Side-by-side diffs Delta from patch set Stats (+111 lines, -69 lines) Patch
M PRESUBMIT.py View 1 chunk +6 lines, -1 line 0 comments Download
M presubmit_canned_checks.py View 4 chunks +10 lines, -2 lines 0 comments Download
M pylintrc View 1 7 chunks +76 lines, -66 lines 0 comments Download
M tests/presubmit_unittest.py View 4 chunks +19 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
M-A Ruel
Once this commit has baked for some time, I'll commit all the other CLs depending ...
8 years, 8 months ago (2012-04-24 15:18:50 UTC) #1
cmp
lgtm
8 years, 8 months ago (2012-04-24 16:22:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10199016/3001
8 years, 8 months ago (2012-04-24 16:43:55 UTC) #3
commit-bot: I haz the power
Presubmit check for 10199016-3001 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 8 months ago (2012-04-24 16:43:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/10199016/3001
8 years, 8 months ago (2012-04-24 16:48:11 UTC) #5
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 16:55:33 UTC) #6
Change committed as 133707

Powered by Google App Engine
This is Rietveld 408576698