OLD | NEW |
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. | 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. |
2 # Use of this source code is governed by a BSD-style license that can be | 2 # Use of this source code is governed by a BSD-style license that can be |
3 # found in the LICENSE file. | 3 # found in the LICENSE file. |
4 | 4 |
5 """Top-level presubmit script for depot tools. | 5 """Top-level presubmit script for depot tools. |
6 | 6 |
7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for | 7 See http://dev.chromium.org/developers/how-tos/depottools/presubmit-scripts for |
8 details on the presubmit API built into depot_tools. | 8 details on the presubmit API built into depot_tools. |
9 """ | 9 """ |
10 | 10 |
11 | 11 |
12 def CommonChecks(input_api, output_api, tests_to_black_list): | 12 def CommonChecks(input_api, output_api, tests_to_black_list): |
13 results = [] | 13 results = [] |
14 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) | 14 results.extend(input_api.canned_checks.CheckOwners(input_api, output_api)) |
15 black_list = list(input_api.DEFAULT_BLACK_LIST) + [ | 15 black_list = list(input_api.DEFAULT_BLACK_LIST) + [ |
16 r'^cpplint\.py$', | 16 r'^cpplint\.py$', |
17 r'^cpplint_chromium\.py$', | 17 r'^cpplint_chromium\.py$', |
18 r'^python_bin[\/\\].+', | 18 r'^python_bin[\/\\].+', |
19 r'^site-packages-py[0-9]\.[0-9][\/\\].+', | 19 r'^site-packages-py[0-9]\.[0-9][\/\\].+', |
20 r'^svn_bin[\/\\].+', | 20 r'^svn_bin[\/\\].+', |
21 r'^testing_support[\/\\]_rietveld[\/\\].+'] | 21 r'^testing_support[\/\\]_rietveld[\/\\].+'] |
| 22 disabled_warnings = [ |
| 23 'R0401', # Cyclic import |
| 24 'W0613', # Unused argument |
| 25 ] |
22 results.extend(input_api.canned_checks.RunPylint( | 26 results.extend(input_api.canned_checks.RunPylint( |
23 input_api, | 27 input_api, |
24 output_api, | 28 output_api, |
25 white_list=[r'.*\.py$'], | 29 white_list=[r'.*\.py$'], |
26 black_list=black_list)) | 30 black_list=black_list, |
| 31 disabled_warnings=disabled_warnings)) |
27 | 32 |
28 # TODO(maruel): Make sure at least one file is modified first. | 33 # TODO(maruel): Make sure at least one file is modified first. |
29 # TODO(maruel): If only tests are modified, only run them. | 34 # TODO(maruel): If only tests are modified, only run them. |
30 results.extend(input_api.canned_checks.RunUnitTestsInDirectory( | 35 results.extend(input_api.canned_checks.RunUnitTestsInDirectory( |
31 input_api, | 36 input_api, |
32 output_api, | 37 output_api, |
33 'tests', | 38 'tests', |
34 whitelist=[r'.*test\.py$'], | 39 whitelist=[r'.*test\.py$'], |
35 blacklist=tests_to_black_list)) | 40 blacklist=tests_to_black_list)) |
36 return results | 41 return results |
(...skipping 59 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... |
96 | 101 |
97 | 102 |
98 def CheckChangeOnCommit(input_api, output_api): | 103 def CheckChangeOnCommit(input_api, output_api): |
99 output = [] | 104 output = [] |
100 output.extend(CommonChecks(input_api, output_api, [])) | 105 output.extend(CommonChecks(input_api, output_api, [])) |
101 output.extend(input_api.canned_checks.CheckDoNotSubmit( | 106 output.extend(input_api.canned_checks.CheckDoNotSubmit( |
102 input_api, | 107 input_api, |
103 output_api)) | 108 output_api)) |
104 output.extend(RunGitClTests(input_api, output_api)) | 109 output.extend(RunGitClTests(input_api, output_api)) |
105 return output | 110 return output |
OLD | NEW |