Issue 10198031: Exclude problematic formats from tests, rather than including all other platforms

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10198031: Exclude problematic formats from tests, rather than including all other platforms (Closed)

Created:
8 years, 8 months ago by Steve Block

Modified:
8 years, 8 months ago

Reviewers:
Nico

Base URL:
http://git.chromium.org/external/gyp.git@master

Visibility:
Public.

More Reviews

Description

Exclude problematic formats from tests, rather than including all other platforms This is more robust to changes in the set of available platforms.

Patch Set 2 : No need to check for gypd #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
M	test/assembly/gyptest-assembly.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/same-gyp-name/gyptest-all.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/same-gyp-name/gyptest-default.py	View	1	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nico

http://codereview.chromium.org/10198031/diff/1/test/assembly/gyptest-assembly.py File test/assembly/gyptest-assembly.py (right): http://codereview.chromium.org/10198031/diff/1/test/assembly/gyptest-assembly.py#newcode16 test/assembly/gyptest-assembly.py:16: test = TestGyp.TestGyp(formats=['!gypd', '!msvs']) Is "!gypd" needed? gyptest.py doesn't ...

8 years, 8 months ago (2012-04-27 05:07:57 UTC) #2

LGTM

r1344

Expand Messages | Collapse Messages

Issue 10198031: Exclude problematic formats from tests, rather than including all other platforms (Closed)

Description

Patch Set 1 #

Patch Set 2 : No need to check for gypd #

Messages