Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h.

Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h.

This addresses a long-standing TODO.  Cleanup is good for the soul.

BUG=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=135145

[robertshield, 2012-05-02 20:05:12]

Thanks for the awesome cleanup! Comments and such:

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
File chrome_frame/test/automation_client_mock.cc (right):

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
chrome_frame/test/automation_client_mock.cc:126:
GetChromeFrameProfilePath(&profile_path_, L"Adam.N.Epilinter");
I'm confused, the prototype is:
// Sets |profile_path| to the path for the Chrome Frame |profile_name| profile.
void GetChromeFrameProfilePath(const std::wstring& profile_name,
                               FilePath* profile_path);

Shouldn't the parameters in this call be reversed?

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
File chrome_frame/test/automation_client_mock.h (right):

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
chrome_frame/test/automation_client_mock.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
2012

http://codereview.chromium.org/10197011/diff/1/chrome_frame/utils.h
File chrome_frame/utils.h (right):

http://codereview.chromium.org/10197011/diff/1/chrome_frame/utils.h#newcode626
chrome_frame/utils.h:626: void GetChromeFrameProfilePath(const std::wstring&
profile_name,
Any reason not to use string16?

[Jói, 2012-05-03 11:41:52]

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
File chrome_frame/test/automation_client_mock.cc (right):

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
chrome_frame/test/automation_client_mock.cc:126:
GetChromeFrameProfilePath(&profile_path_, L"Adam.N.Epilinter");
On 2012/05/02 20:05:13, robertshield wrote:
> I'm confused, the prototype is:
> // Sets |profile_path| to the path for the Chrome Frame |profile_name|
profile.
> void GetChromeFrameProfilePath(const std::wstring& profile_name,
>                                FilePath* profile_path);
> 
> Shouldn't the parameters in this call be reversed?

Whoops, forgot to upload latest.  Uploaded now.

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
File chrome_frame/test/automation_client_mock.h (right):

http://codereview.chromium.org/10197011/diff/1/chrome_frame/test/automation_c...
chrome_frame/test/automation_client_mock.h:1: // Copyright (c) 2011 The Chromium
Authors. All rights reserved.
On 2012/05/02 20:05:13, robertshield wrote:
> 2012

Done.

http://codereview.chromium.org/10197011/diff/1/chrome_frame/utils.h
File chrome_frame/utils.h (right):

http://codereview.chromium.org/10197011/diff/1/chrome_frame/utils.h#newcode626
chrome_frame/utils.h:626: void GetChromeFrameProfilePath(const std::wstring&
profile_name,
On 2012/05/02 20:05:13, robertshield wrote:
> Any reason not to use string16?

Yes, laziness.  Fixed now :)

[robertshield, 2012-05-03 13:22:34]

Awesome, LGTM!

[commit-bot: I haz the power, 2012-05-03 13:29:58]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10197011/23002

[commit-bot: I haz the power, 2012-05-03 14:49:07]

Change committed as 135145