Share the "get CF profile dir" code between ChromeFramePlugin and chrome_frame_test_utils.h.

chrome_frame/test/automation_client_mock.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome_frame/test/automation_client_mock.h"
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "chrome/common/automation_messages.h"
 #include "chrome_frame/custom_sync_call_context.h"
@@ skipping 105 matching lines @@
   scoped_refptr<ChromeFrameAutomationClient> client_;
   scoped_refptr<ChromeFrameLaunchParams> launch_params_;
   chrome_frame_test::TimedMsgLoop loop_;
 };
 
 // static
 FilePath CFACWithChrome::profile_path_;
 
 // static
 void CFACWithChrome::SetUpTestCase() {
-  profile_path_ = chrome_frame_test::GetProfilePath(L"Adam.N.Epilinter");
+  GetChromeFrameProfilePath(&profile_path_, L"Adam.N.Epilinter");

[robertshield, 2012/05/02 20:05:13]

I'm confused, the prototype is:
// Sets |profile_path| to the path for the Chrome Frame |profile_name| profile.
void GetChromeFrameProfilePath(const std::wstring& profile_name,
                               FilePath* profile_path);

Shouldn't the parameters in this call be reversed?

[Jói, 2012/05/03 11:41:52]

Whoops, forgot to upload latest.  Uploaded now.

 }
 
 // static
 void CFACWithChrome::TearDownTestCase() {
   profile_path_.clear();
 }
 
 void CFACWithChrome::SetUp() {
   chrome_frame_test::OverrideDataDirectoryForThisTest(profile_path_.value());
   client_ = new ChromeFrameAutomationClient();
@@ skipping 326 matching lines @@
           GURL("http://www.nonexistent.com"), empty, profile_path_,
           profile_path_.BaseName().value(), L"", false, false, false, false));
   launch_params->set_launch_timeout(timeout);
   launch_params->set_version_check(false);
   EXPECT_TRUE(client_->Initialize(&cfd_, launch_params));
   loop_.RunFor(base::TimeDelta::FromSeconds(10));
 
   EXPECT_CALL(mock_proxy_, ReleaseTabProxy(testing::Eq(tab_handle_))).Times(1);
   client_->Uninitialize();
 }