Issue 10197004: [Sync] Convert SyncSessionSnapshot to a copy-able class.

Issue 10197004: [Sync] Convert SyncSessionSnapshot to a copy-able class. (Closed)

Created:
8 years, 8 months ago by Nicolas Zea

Modified:
8 years, 8 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[Sync] Convert SyncSessionSnapshot to a copy-able class. Previously it was an immutable struct that was passed around by making dynamic allocations and passing pointers. We now just have a class with only getters and no setters, but support for default copy and assign. This cleans up some code and makes some future work easier to pass snapshots around. BUG=none TEST=sync_unit_tests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133747

Patch Set 1 #

Patch Set 2 : Fix ModelTypeToPayloadMap value conversion #

Patch Set 3 : lint #

Total comments: 4

Patch Set 4 : Address comments. #

Created: 8 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+491 lines, -456 lines)			Patch
M	chrome/browser/sync/backend_migrator.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.h	View		5 chunks	+4 lines, -7 lines	0 comments	Download
M	chrome/browser/sync/glue/sync_backend_host.cc	View		7 chunks	+11 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.h	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_harness.cc	View		11 chunks	+49 lines, -60 lines	0 comments	Download
M	chrome/browser/sync/profile_sync_service_mock.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/retry_verifier.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	chrome/browser/sync/retry_verifier.cc	View		3 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/sync_ui_util.cc	View		5 chunks	+34 lines, -41 lines	0 comments	Download
M	chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc	View		2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/sync/test_profile_sync_service.cc	View		2 chunks	+4 lines, -4 lines	0 comments	Download
A	sync/engine/sync_engine_event.h	View	1 2	1 chunk	+78 lines, -0 lines	0 comments	Download
A +	sync/engine/sync_engine_event.cc	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	sync/engine/sync_scheduler.cc	View		2 chunks	+4 lines, -6 lines	0 comments	Download
M	sync/engine/sync_scheduler_unittest.cc	View	1	20 chunks	+38 lines, -37 lines	0 comments	Download
M	sync/engine/syncer_command.cc	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	sync/engine/syncer_types.h	View		2 chunks	+0 lines, -71 lines	0 comments	Download
D	sync/engine/syncer_types.cc	View		1 chunk	+0 lines, -15 lines	0 comments	Download
M	sync/internal_api/all_status.h	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	sync/internal_api/all_status.cc	View		3 chunks	+20 lines, -20 lines	0 comments	Download
M	sync/internal_api/debug_info_event_listener.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sync/internal_api/debug_info_event_listener.cc	View		1 chunk	+9 lines, -12 lines	0 comments	Download
M	sync/internal_api/js_sync_manager_observer.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sync/internal_api/js_sync_manager_observer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	sync/internal_api/js_sync_manager_observer_unittest.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sync/internal_api/sync_manager.h	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	sync/internal_api/sync_manager.cc	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	sync/internal_api/syncapi_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sync/sessions/session_state.h	View	1 2 3	2 chunks	+47 lines, -27 lines	0 comments	Download
M	sync/sessions/session_state.cc	View		3 chunks	+129 lines, -60 lines	0 comments	Download
M	sync/sessions/session_state_unittest.cc	View		2 chunks	+2 lines, -25 lines	0 comments	Download
M	sync/sessions/sync_session.cc	View		3 chunks	+4 lines, -5 lines	0 comments	Download
M	sync/sessions/sync_session_context.h	View		3 chunks	+1 line, -4 lines	0 comments	Download
M	sync/sessions/sync_session_context.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	sync/sync.gyp	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	sync/syncable/model_type_payload_map.cc	View	1 2 3	2 chunks	+6 lines, -1 line	0 comments	Download
M	sync/syncable/model_type_payload_map_unittest.cc	View	1 2 3	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

tim (not reviewing)

LGTM with a few comments http://codereview.chromium.org/10197004/diff/6001/sync/sessions/session_state.h File sync/sessions/session_state.h (right): http://codereview.chromium.org/10197004/diff/6001/sync/sessions/session_state.h#newcode104 sync/sessions/session_state.h:104: // refs. remove http://codereview.chromium.org/10197004/diff/6001/sync/syncable/model_type_payload_map.cc ...

8 years, 8 months ago (2012-04-24 01:22:08 UTC) #2

Nicolas Zea

http://codereview.chromium.org/10197004/diff/6001/sync/sessions/session_state.h File sync/sessions/session_state.h (right): http://codereview.chromium.org/10197004/diff/6001/sync/sessions/session_state.h#newcode104 sync/sessions/session_state.h:104: // refs. On 2012/04/24 01:22:08, timsteele wrote: > remove ...

8 years, 8 months ago (2012-04-24 18:06:51 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/10197004/9001

8 years, 8 months ago (2012-04-24 18:06:59 UTC) #4

Change committed as 133747

Expand Messages | Collapse Messages