sync/internal_api/js_sync_manager_observer.cc - Issue 10197004: [Sync] Convert SyncSessionSnapshot to a copy-able class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sync/internal_api/js_sync_manager_observer.cc

Issue 10197004: [Sync] Convert SyncSessionSnapshot to a copy-able class. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments. Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: sync/internal_api/js_sync_manager_observer.cc

diff --git a/sync/internal_api/js_sync_manager_observer.cc b/sync/internal_api/js_sync_manager_observer.cc

index b9cf9f320c644185c3da152fd2b1048d0261bfa1..5aa9dc34ca9632563c6070d89ad68eb49e302cbe 100644

--- a/sync/internal_api/js_sync_manager_observer.cc

+++ b/sync/internal_api/js_sync_manager_observer.cc

@@ -31,12 +31,12 @@ void JsSyncManagerObserver::SetJsEventHandler(

}

void JsSyncManagerObserver::OnSyncCycleCompleted(

- const sessions::SyncSessionSnapshot* snapshot) {

+ const sessions::SyncSessionSnapshot& snapshot) {

if (!event_handler_.IsInitialized()) {

return;

}

DictionaryValue details;

- details.Set("snapshot", snapshot->ToValue());

+ details.Set("snapshot", snapshot.ToValue());

HandleJsEvent(FROM_HERE, "onSyncCycleCompleted", JsEventDetails(&details));

}