Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 10191011: Moving dgen_ scripts out of validator_arm into a common directory. (Closed)

Created:
8 years, 8 months ago by petarj
Modified:
8 years, 6 months ago
CC:
native-client-reviews_googlegroups.com, Karl
Visibility:
Public.

Description

Moving dgen_ scripts out of validator_arm into a common directory. The dgen_* scripts have been lifted into a common directory so other architectures, such as MIPS, can reuse the scripts without duplicating the code. BUG= http://code.google.com/p/nativeclient/issues/detail?id=2275 TEST=none

Patch Set 1 #

Patch Set 2 : Updates per code review. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1957 lines) Patch
A + src/trusted/validator/dgen/dgen_core.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/dgen_decoder_output.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/dgen_dump.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/dgen_input.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/dgen_opt.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/dgen_output.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/dgen_test_output.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/generate_decoder.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
A + src/trusted/validator/dgen/optimize-table.py View 1 0 chunks +-1 lines, --1 lines 0 comments Download
M src/trusted/validator_arm/build.scons View 1 3 chunks +14 lines, -7 lines 0 comments Download
D src/trusted/validator_arm/dgen_core.py View 1 chunk +0 lines, -449 lines 0 comments Download
D src/trusted/validator_arm/dgen_decoder_output.py View 1 chunk +0 lines, -273 lines 0 comments Download
D src/trusted/validator_arm/dgen_dump.py View 1 chunk +0 lines, -50 lines 0 comments Download
D src/trusted/validator_arm/dgen_input.py View 1 chunk +0 lines, -316 lines 0 comments Download
D src/trusted/validator_arm/dgen_opt.py View 1 chunk +0 lines, -76 lines 0 comments Download
D src/trusted/validator_arm/dgen_output.py View 1 chunk +0 lines, -32 lines 0 comments Download
D src/trusted/validator_arm/dgen_test_output.py View 1 chunk +0 lines, -647 lines 0 comments Download
D src/trusted/validator_arm/generate_decoder.py View 1 chunk +0 lines, -79 lines 0 comments Download
D src/trusted/validator_arm/optimize-table.py View 1 chunk +0 lines, -37 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
petarj
Per code review at http://codereview.chromium.org/9979025/, we need to move dgen_* scripts into a common directory, ...
8 years, 8 months ago (2012-04-23 20:53:36 UTC) #1
Nick Bray (chromium)
I'd put the scripts inside a "dgen" directory, to keep things tidy. What parts of ...
8 years, 8 months ago (2012-04-24 00:45:29 UTC) #2
petarj
The change has been updated. The scripts have been moved into validator/dgen directory. @Nick To ...
8 years, 8 months ago (2012-04-24 18:14:25 UTC) #3
Nick Bray (chromium)
Petar, meet Karl. Karl, meet Petar. In my zeal to prevent code from being duplicated, ...
8 years, 8 months ago (2012-04-24 19:57:56 UTC) #4
petarj
Nick, Karl, if the changes Karl is introducing are not going to be arch-specific or ...
8 years, 8 months ago (2012-04-24 22:16:09 UTC) #5
Karl
Petarj, Right now, I'm working on building a good testing strategy for the decoder tables, ...
8 years, 8 months ago (2012-04-24 22:32:22 UTC) #6
petarj
Karl, I am fine with that. Nick, are you fine then that we leave the ...
8 years, 8 months ago (2012-04-24 22:40:46 UTC) #7
Nick Bray (chromium)
Sure, although I'd still suggest keeping them in a directory. Sorry for running you in ...
8 years, 8 months ago (2012-04-24 22:48:12 UTC) #8
Nick Bray (chromium)
8 years, 8 months ago (2012-04-24 22:51:39 UTC) #9
I should mention, in case you haven't done this yet, when you want me to take
another look at previous CL, just reply "PTAL" (please take another look) on the
review.

Powered by Google App Engine
This is Rietveld 408576698