Remove net-internals page for throttling, introduce flag for extension devs instead.

Remove net-internals page for throttling, introduce flag for extension devs instead.

Change throttling error page to state it is extension-specific and point straight to http://dev.chromium.org/throttling instead of to the net-internals page.

BUG=119760
TEST=There should no longer be an "HTTP Throttling" tab under chrome://net-internals/. Throttling should be on by default for requests originated by extensions, but passing --disable-extensions-http-throttling should disable the behavior.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133700

[eroman, 2012-04-23 21:28:03]

lgtm

http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
chrome/app/generated_resources.grd:8022: +        visit <ph
name="NET_INTERNALS_PAGE">&lt;strong&gt;http://dev.chromium.org/throttling&lt;/strong&gt;</ph>,
Can you change the placeholder name? "NET_INTERNALS_PAGE" is no longer
descriptive.

http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
chrome/app/generated_resources.grd:8026: +        Extension requests to this URL
have been temporarily throttled.
Do you expect users to ever see this page?

Probably the requests being done by extensions are not tied to a window frame,
and are just background requests like XMLHttpRequests. 

In which case when it fails, there will be no UI.

I think the place to put such warnings should be somewhere like the
webinsepctor, where developers will go to inspect the network failures.

http://codereview.chromium.org/10185003/diff/1/chrome/common/pref_names.cc
File chrome/common/pref_names.cc (left):

http://codereview.chromium.org/10185003/diff/1/chrome/common/pref_names.cc#ol...
chrome/common/pref_names.cc:876: const char kHttpThrottlingEnabled[] =
"http_throttling.enabled";
Is there any other policy when removing chrome preferences? (Such as updating
the on-disk prefs file? Or is that handled automatically).

[eroman, 2012-04-23 21:29:58]

http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
File chrome/app/generated_resources.grd (right):

http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
chrome/app/generated_resources.grd:8026: +        Extension requests to this URL
have been temporarily throttled.
On 2012/04/23 21:28:03, eroman wrote:
> Do you expect users to ever see this page?
> 
> Probably the requests being done by extensions are not tied to a window frame,
> and are just background requests like XMLHttpRequests. 
> 
> In which case when it fails, there will be no UI.
> 
> I think the place to put such warnings should be somewhere like the
> webinsepctor, where developers will go to inspect the network failures.

Oh nevermind, I see now that Yuzhu is working on that :)

[Jói, 2012-04-23 21:54:37]

> chrome/app/generated_resources.grd:8022: +        visit <ph
>
name="NET_INTERNALS_PAGE">&lt;strong&gt;http://dev.chromium.org/throttling&lt;/strong&gt;</ph>,
> Can you change the placeholder name? "NET_INTERNALS_PAGE" is no longer
> descriptive.

Changed the placeholder name to URL_FOR_MORE_INFO.

> Probably the requests being done by extensions are not tied to a window
> frame, and are just background requests like XMLHttpRequests.
>
> In which case when it fails, there will be no UI.

Right, I expect the error page will be seen very infrequently or not
at all (I'm unsure as to what the origin would be for an iframe
embedded in a chrome-extension://... web page).  As you noticed, Yuzhu
is working on surfacing these errors in a nicer way in the JavaScript
console.

> Is there any other policy when removing chrome preferences? (Such as
> updating the on-disk prefs file? Or is that handled automatically).

You don't need to do anything special when you remove a preference.  I
asked Bernhard Bauer to validate this the last time I did, see his
response on http://codereview.chromium.org/9836043/

Cheers,
Jói



On Mon, Apr 23, 2012 at 9:28 PM,  <eroman@chromium.org> wrote:
> lgtm
>
>
>
>
>
http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
> File chrome/app/generated_resources.grd (right):
>
>
http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
> chrome/app/generated_resources.grd:8022: +        visit <ph
>
name="NET_INTERNALS_PAGE">&lt;strong&gt;http://dev.chromium.org/throttling&lt;/strong&gt;</ph>,
> Can you change the placeholder name? "NET_INTERNALS_PAGE" is no longer
> descriptive.
>
>
http://codereview.chromium.org/10185003/diff/1/chrome/app/generated_resources...
> chrome/app/generated_resources.grd:8026: +        Extension requests to
> this URL have been temporarily throttled.
> Do you expect users to ever see this page?
>
> Probably the requests being done by extensions are not tied to a window
> frame, and are just background requests like XMLHttpRequests.
>
> In which case when it fails, there will be no UI.
>
> I think the place to put such warnings should be somewhere like the
> webinsepctor, where developers will go to inspect the network failures.
>
> http://codereview.chromium.org/10185003/diff/1/chrome/common/pref_names.cc
> File chrome/common/pref_names.cc (left):
>
>
http://codereview.chromium.org/10185003/diff/1/chrome/common/pref_names.cc#ol...
> chrome/common/pref_names.cc:876: const char kHttpThrottlingEnabled[] =
> "http_throttling.enabled";
> Is there any other policy when removing chrome preferences? (Such as
> updating the on-disk prefs file? Or is that handled automatically).
>
> http://codereview.chromium.org/10185003/

[commit-bot: I haz the power, 2012-04-24 14:43:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10185003/13001

[commit-bot: I haz the power, 2012-04-24 14:43:26]

Presubmit check for 10185003-13001 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
See the JavaScript style guide at
http://www.chromium.org/developers/web-development-style-guide#TOC-JavaScript
and if you have any feedback about the JavaScript PRESUBMIT check, contact
tbreisacher@chromium.org

** Presubmit Warnings **
Found JavaScript style violations in
chrome/test/data/webui/net_internals/net_internals_test.js:
  line 394: E0010: Missing semicolon at end of line
  }
  ^
  line 622: E0131: Single-quoted string preferred over double-quoted string.
    this.time = "" + time;
                ^

Presubmit checks took 2.9s to calculate.

[commit-bot: I haz the power, 2012-04-24 14:46:51]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/joi@chromium.org/10185003/9003

[commit-bot: I haz the power, 2012-04-24 16:14:33]

Change committed as 133700