Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Side by Side Diff: chrome/browser/net/net_pref_observer.cc

Issue 10185003: Remove net-internals page for throttling, introduce flag for extension devs instead. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix JavaScript presubmit. Created 8 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/net/net_pref_observer.h" 5 #include "chrome/browser/net/net_pref_observer.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "chrome/browser/net/predictor.h" 8 #include "chrome/browser/net/predictor.h"
9 #include "chrome/browser/prefs/pref_service.h" 9 #include "chrome/browser/prefs/pref_service.h"
10 #include "chrome/browser/prerender/prerender_manager.h" 10 #include "chrome/browser/prerender/prerender_manager.h"
11 #include "chrome/browser/profiles/profile.h" 11 #include "chrome/browser/profiles/profile.h"
12 #include "chrome/common/chrome_notification_types.h" 12 #include "chrome/common/chrome_notification_types.h"
13 #include "chrome/common/pref_names.h" 13 #include "chrome/common/pref_names.h"
14 #include "content/public/browser/browser_thread.h" 14 #include "content/public/browser/browser_thread.h"
15 #include "content/public/browser/notification_details.h" 15 #include "content/public/browser/notification_details.h"
16 #include "net/http/http_stream_factory.h" 16 #include "net/http/http_stream_factory.h"
17 #include "net/url_request/url_request_throttler_manager.h"
18 17
19 using content::BrowserThread; 18 using content::BrowserThread;
20 19
21 namespace {
22
23 // Callback function to call the set_enforce_throttling member on the
24 // URLRequestThrottlerManager singleton.
25 void SetEnforceThrottlingOnThrottlerManager(bool enforce) {
26 net::URLRequestThrottlerManager::GetInstance()->set_enforce_throttling(
27 enforce);
28 }
29
30 }
31
32 NetPrefObserver::NetPrefObserver(PrefService* prefs, 20 NetPrefObserver::NetPrefObserver(PrefService* prefs,
33 prerender::PrerenderManager* prerender_manager, 21 prerender::PrerenderManager* prerender_manager,
34 chrome_browser_net::Predictor* predictor) 22 chrome_browser_net::Predictor* predictor)
35 : prerender_manager_(prerender_manager), 23 : prerender_manager_(prerender_manager),
36 predictor_(predictor) { 24 predictor_(predictor) {
37 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 25 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
38 DCHECK(prefs); 26 DCHECK(prefs);
39 DCHECK(predictor); 27 DCHECK(predictor);
40 28
41 network_prediction_enabled_.Init(prefs::kNetworkPredictionEnabled, prefs, 29 network_prediction_enabled_.Init(prefs::kNetworkPredictionEnabled, prefs,
42 this); 30 this);
43 spdy_disabled_.Init(prefs::kDisableSpdy, prefs, this); 31 spdy_disabled_.Init(prefs::kDisableSpdy, prefs, this);
44 http_throttling_enabled_.Init(prefs::kHttpThrottlingEnabled, prefs, this);
45 32
46 ApplySettings(NULL); 33 ApplySettings(NULL);
47 } 34 }
48 35
49 NetPrefObserver::~NetPrefObserver() { 36 NetPrefObserver::~NetPrefObserver() {
50 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 37 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
51 } 38 }
52 39
53 void NetPrefObserver::Observe(int type, 40 void NetPrefObserver::Observe(int type,
54 const content::NotificationSource& source, 41 const content::NotificationSource& source,
55 const content::NotificationDetails& details) { 42 const content::NotificationDetails& details) {
56 DCHECK_EQ(type, chrome::NOTIFICATION_PREF_CHANGED); 43 DCHECK_EQ(type, chrome::NOTIFICATION_PREF_CHANGED);
57 44
58 std::string* pref_name = content::Details<std::string>(details).ptr(); 45 std::string* pref_name = content::Details<std::string>(details).ptr();
59 ApplySettings(pref_name); 46 ApplySettings(pref_name);
60 } 47 }
61 48
62 void NetPrefObserver::ApplySettings(const std::string* pref_name) { 49 void NetPrefObserver::ApplySettings(const std::string* pref_name) {
63 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 50 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
64 51
65 predictor_->EnablePredictor(*network_prediction_enabled_); 52 predictor_->EnablePredictor(*network_prediction_enabled_);
66 if (prerender_manager_) 53 if (prerender_manager_)
67 prerender_manager_->set_enabled(*network_prediction_enabled_); 54 prerender_manager_->set_enabled(*network_prediction_enabled_);
68 net::HttpStreamFactory::set_spdy_enabled(!*spdy_disabled_); 55 net::HttpStreamFactory::set_spdy_enabled(!*spdy_disabled_);
69
70 if (!pref_name || *pref_name == prefs::kHttpThrottlingEnabled) {
71 BrowserThread::PostTask(
72 BrowserThread::IO, FROM_HERE,
73 base::Bind(&SetEnforceThrottlingOnThrottlerManager,
74 *http_throttling_enabled_));
75 }
76 } 56 }
77 57
78 // static 58 // static
79 void NetPrefObserver::RegisterPrefs(PrefService* prefs) { 59 void NetPrefObserver::RegisterPrefs(PrefService* prefs) {
80 prefs->RegisterBooleanPref(prefs::kNetworkPredictionEnabled, 60 prefs->RegisterBooleanPref(prefs::kNetworkPredictionEnabled,
81 true, 61 true,
82 PrefService::SYNCABLE_PREF); 62 PrefService::SYNCABLE_PREF);
83 prefs->RegisterBooleanPref(prefs::kDisableSpdy, 63 prefs->RegisterBooleanPref(prefs::kDisableSpdy,
84 false, 64 false,
85 PrefService::UNSYNCABLE_PREF); 65 PrefService::UNSYNCABLE_PREF);
86 prefs->RegisterBooleanPref(prefs::kHttpThrottlingEnabled,
87 true,
88 PrefService::UNSYNCABLE_PREF);
89 } 66 }
OLDNEW
« no previous file with comments | « chrome/browser/net/net_pref_observer.h ('k') | chrome/browser/resources/net_internals/browser_bridge.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698