Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(366)

Issue 10184011: Remove unused parameter "stream" from all variants of OnMoreData(). (Closed)

Created:
8 years, 8 months ago by enal
Modified:
8 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Remove unused parameter "stream" from all variants of OnMoreData(). (Also fixing some minor lint errors...) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=133726

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+79 lines, -89 lines) Patch
M media/audio/android/audio_track_output_android.cc View 2 chunks +2 lines, -1 line 0 comments Download
M media/audio/android/opensles_output.cc View 1 chunk +0 lines, -1 line 0 comments Download
M media/audio/audio_io.h View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/audio_low_latency_input_output_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M media/audio/audio_output_controller.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/audio_output_controller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M media/audio/audio_output_mixer.h View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/audio_output_mixer.cc View 1 3 chunks +1 line, -4 lines 0 comments Download
M media/audio/audio_output_proxy_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M media/audio/fake_audio_output_stream.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/linux/alsa_output.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/linux/alsa_output_unittest.cc View 5 chunks +5 lines, -8 lines 0 comments Download
M media/audio/linux/cras_output.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M media/audio/linux/cras_output_unittest.cc View 8 chunks +9 lines, -8 lines 0 comments Download
M media/audio/mac/audio_low_latency_output_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_output_mac.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/mac/audio_output_mac_unittest.cc View 1 2 4 chunks +9 lines, -8 lines 0 comments Download
M media/audio/pulse/pulse_output.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/simple_sources.h View 2 chunks +2 lines, -4 lines 0 comments Download
M media/audio/simple_sources.cc View 3 chunks +3 lines, -5 lines 0 comments Download
M media/audio/simple_sources_unittest.cc View 2 chunks +3 lines, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/audio/win/audio_low_latency_output_win_unittest.cc View 5 chunks +5 lines, -7 lines 0 comments Download
M media/audio/win/audio_output_win_unittest.cc View 7 chunks +19 lines, -18 lines 0 comments Download
M media/audio/win/waveout_output_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
enal1
Victoria, can you please take a look? Just minor code cleanup (though containing two dozen ...
8 years, 8 months ago (2012-04-23 20:01:45 UTC) #1
vrk (LEFT CHROMIUM)
LGTM Great cleanup, thanks enal!
8 years, 8 months ago (2012-04-24 00:18:40 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/10184011/1
8 years, 8 months ago (2012-04-24 03:58:59 UTC) #3
commit-bot: I haz the power
Try job failure for 10184011-1 (retry) on linux_chromeos for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-24 04:16:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/10184011/19002
8 years, 8 months ago (2012-04-24 15:34:21 UTC) #5
commit-bot: I haz the power
Try job failure for 10184011-19002 (retry) on mac_rel for step "compile" (clobber build). It's a ...
8 years, 8 months ago (2012-04-24 16:02:23 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/enal@chromium.org/10184011/25002
8 years, 8 months ago (2012-04-24 16:23:59 UTC) #7
commit-bot: I haz the power
8 years, 8 months ago (2012-04-24 18:02:15 UTC) #8
Change committed as 133726

Powered by Google App Engine
This is Rietveld 408576698