Support painting panels with chromium themes on GTK.

chrome/browser/ui/gtk/browser_window_gtk.cc

Index: chrome/browser/ui/gtk/browser_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/browser_window_gtk.cc b/chrome/browser/ui/gtk/browser_window_gtk.cc
index c30674c868c2acf0b20a20f225959c9be4dc9dde..17835d6f598f499bc04fc6d08dd9dae5a5a3f2a0 100644
--- a/chrome/browser/ui/gtk/browser_window_gtk.cc
+++ b/chrome/browser/ui/gtk/browser_window_gtk.cc
@@ -910,7 +910,7 @@ void BrowserWindowGtk::Restore() {
 }
 
 bool BrowserWindowGtk::ShouldDrawContentDropShadow() {
-  return !IsMaximized() && UseCustomFrame();
+  return !IsMaximized() && !IsMinimized() && UseCustomFrame();

[jennb, 2012/04/27 18:36:13]

Suggest overriding ShouldDrawContentDropShadow() in PanelBrowserWindowGtk
instead. That also avoids the confusion of adding IsMinimized to
PanelBrowserWindowGtk and avoids altering base class behavior in a patch that
should only affect Panels.

[jianli, 2012/04/27 20:22:34]

Done.

 }
 
 void BrowserWindowGtk::EnterFullscreen(
@@ -2451,8 +2451,7 @@ bool BrowserWindowGtk::IsBookmarkBarSupported() const {
 bool BrowserWindowGtk::UsingCustomPopupFrame() const {
   ThemeServiceGtk* theme_provider = ThemeServiceGtk::GetFrom(
       browser()->profile());
-  return !theme_provider->UsingNativeTheme() &&
-         (browser()->is_type_popup() || browser()->is_type_panel());

[jennb, 2012/04/27 18:36:13]

FYI - (not for this patch) There are still other uses of is_type_panel() in this
base class. Now that we have a subclass, is it possible to move the remaining
panel-specific logic to the subclass?

+  return !theme_provider->UsingNativeTheme() && browser()->is_type_popup();
 }
 
 BrowserTitlebar* BrowserWindowGtk::CreateBrowserTitlebar() {
@@ -2558,12 +2557,6 @@ void BrowserWindowGtk::PlaceBookmarkBar(bool is_floating) {
   }
 }
 
-BrowserWindowGtk::TitleDecoration BrowserWindowGtk::GetWindowTitle(
-    std::string* title) const {
-  *title = UTF16ToUTF8(browser()->GetWindowTitleForCurrentTab());
-  return PLAIN_TEXT;
-}
-
 // static
 bool BrowserWindowGtk::GetCustomFramePrefDefault() {
   // Ideally, we'd use the custom frame by default and just fall back on using