Support painting panels with chromium themes on GTK.

chrome/browser/ui/gtk/browser_window_gtk.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/gtk/browser_window_gtk.h"
 
 #include <dlfcn.h>
 #include <gdk/gdkkeysyms.h>
 
 #include <algorithm>
@@ skipping 892 matching lines @@
 }
 
 void BrowserWindowGtk::Restore() {
   if (IsMaximized())
     UnMaximize();
   else if (IsMinimized())
     gtk_window_deiconify(window_);
 }
 
 bool BrowserWindowGtk::ShouldDrawContentDropShadow() {
-  return !IsMaximized() && UseCustomFrame();
+  return !IsMaximized() && !IsMinimized() && UseCustomFrame();

[jennb, 2012/04/27 18:36:13]

Suggest overriding ShouldDrawContentDropShadow() in PanelBrowserWindowGtk
instead. That also avoids the confusion of adding IsMinimized to
PanelBrowserWindowGtk and avoids altering base class behavior in a patch that
should only affect Panels.

[jianli, 2012/04/27 20:22:34]

Done.

 }
 
 void BrowserWindowGtk::EnterFullscreen(
       const GURL& url, FullscreenExitBubbleType type) {
   // gtk_window_(un)fullscreen asks the window manager to toggle the EWMH
   // for fullscreen windows.  Not all window managers support this.
   gtk_window_fullscreen(window_);
   fullscreen_exit_bubble_type_ = type;
 }
 
@@ skipping 1520 matching lines @@
          browser_->SupportsWindowFeature(Browser::FEATURE_LOCATIONBAR);
 }
 
 bool BrowserWindowGtk::IsBookmarkBarSupported() const {
   return browser_->SupportsWindowFeature(Browser::FEATURE_BOOKMARKBAR);
 }
 
 bool BrowserWindowGtk::UsingCustomPopupFrame() const {
   ThemeServiceGtk* theme_provider = ThemeServiceGtk::GetFrom(
       browser()->profile());
-  return !theme_provider->UsingNativeTheme() &&
-         (browser()->is_type_popup() || browser()->is_type_panel());

[jennb, 2012/04/27 18:36:13]

FYI - (not for this patch) There are still other uses of is_type_panel() in this
base class. Now that we have a subclass, is it possible to move the remaining
panel-specific logic to the subclass?

+  return !theme_provider->UsingNativeTheme() && browser()->is_type_popup();
 }
 
 BrowserTitlebar* BrowserWindowGtk::CreateBrowserTitlebar() {
   return new BrowserTitlebar(this, window_);
 }
 
 bool BrowserWindowGtk::GetWindowEdge(int x, int y, GdkWindowEdge* edge) {
   if (!UseCustomFrame())
     return false;
 
@@ skipping 85 matching lines @@
   GtkWidget* parent = gtk_widget_get_parent(bookmark_bar_->widget());
   if (parent != target_parent) {
     if (parent)
       gtk_container_remove(GTK_CONTAINER(parent), bookmark_bar_->widget());
 
     gtk_box_pack_end(GTK_BOX(target_parent), bookmark_bar_->widget(),
                      FALSE, FALSE, 0);
   }
 }
 
-BrowserWindowGtk::TitleDecoration BrowserWindowGtk::GetWindowTitle(
-    std::string* title) const {
-  *title = UTF16ToUTF8(browser()->GetWindowTitleForCurrentTab());
-  return PLAIN_TEXT;
-}
-
 // static
 bool BrowserWindowGtk::GetCustomFramePrefDefault() {
   // Ideally, we'd use the custom frame by default and just fall back on using
   // system decorations for the few (?) tiling window managers where the custom
   // frame doesn't make sense (e.g. awesome, ion3, ratpoison, xmonad, etc.) or
   // other WMs where it has issues (e.g. Fluxbox -- see issue 19130).  The EWMH
   // _NET_SUPPORTING_WM property makes it easy to look up a name for the current
   // WM, but at least some of the WMs in the latter group don't set it.
   // Instead, we default to using system decorations for all WMs and
   // special-case the ones where the custom frame should be used.
   ui::WindowManagerName wm_type = ui::GuessWindowManager();
   return (wm_type == ui::WM_BLACKBOX ||
           wm_type == ui::WM_COMPIZ ||
           wm_type == ui::WM_ENLIGHTENMENT ||
           wm_type == ui::WM_METACITY ||
           wm_type == ui::WM_MUTTER ||
           wm_type == ui::WM_OPENBOX ||
           wm_type == ui::WM_XFWM4);
 }
 
 // static
 BrowserWindow* BrowserWindow::CreateBrowserWindow(Browser* browser) {
   BrowserWindowGtk* browser_window_gtk = new BrowserWindowGtk(browser);
   browser_window_gtk->Init();
   return browser_window_gtk;
 }