Create an external source for extensions on linux that meets the needs of package managers.

chrome/browser/extensions/external_extension_util.h

Index: chrome/browser/extensions/external_extension_util.h
diff --git a/chrome/browser/extensions/external_extension_util.h b/chrome/browser/extensions/external_extension_util.h
new file mode 100644
index 0000000000000000000000000000000000000000..f9ef96d8c53b267c4bc7d0b0a29759dadd0e37c0
--- /dev/null
+++ b/chrome/browser/extensions/external_extension_util.h
@@ -0,0 +1,23 @@
+// Copyright (c) 2012 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_UTIL_H__

[Finnur, 2012/04/24 13:03:24]

This is old school. New files use single trailing underscore (not two).

[Alexandre Abreu, 2012/04/24 19:30:30]

Done.

+#define CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_UTIL_H__
+#pragma once
+
+namespace base {
+class DictionaryValue;
+class ValueSerializer;
+}
+class FilePath;
+
+// Provides various utility functions for external extension manipulation.
+class ExternalExtensionUtil {

[Finnur, 2012/04/24 13:03:24]

Files and classes that end in Util tend to accumulate junk over time. In this
case, however, I'm not even sure a separate file for this util function is
warranted since this function isn't shared with any other code. You could just
put it in a namespace {} at the .cc file where you use it and if we need to
share it elsewhere we can always move it.

[Sam Kerner (Chrome), 2012/04/24 15:27:54]

This is used in external_filesystem_extension_loader_linux.cc and
external_pref_extension_loader.cc .  

+ public:
+  static base::DictionaryValue* ExtractPrefs(const FilePath& path,
+                                             base::ValueSerializer* serializer);

[Finnur, 2012/04/24 13:03:24]

Can we use the WARN_ON_UNUSED_RESULT macro for this function?

+};

[Finnur, 2012/04/24 13:03:24]

It feels like this should be a namespace and not a class... No?

Also, the function is missing comments (see my comment in .cc file).

+
+#endif  // CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_UTIL_H__
+