chrome/browser/extensions/external_extension_util.h - Issue 10179002: Create an external source for extensions on linux that meets the needs of package managers.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/extensions/external_extension_util.h

Issue 10179002: Create an external source for extensions on linux that meets the needs of package managers. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 8 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« AUTHORS ('K') | « chrome/browser/extensions/external_extension_provider_impl.cc ('k') | chrome/browser/extensions/external_extension_util.cc » ('j') | chrome/browser/extensions/external_extension_util.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_UTIL_H__
	Finnur 2012/04/24 13:03:24 This is old school. New files use single trailing This is old school. New files use single trailing underscore (not two). Alexandre Abreu 2012/04/24 19:30:30 Done. Show quoted text On 2012/04/24 13:03:24, Finnur wrote: > This is old school. New files use single trailing underscore (not two). Done.
	6 #define CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_UTIL_H__

	7 #pragma once

	8

	9 namespace base {

	10 class DictionaryValue;

	11 class ValueSerializer;

	12 }

	13 class FilePath;

	14

	15 // Provides various utility functions for external extension manipulation.

	16 class ExternalExtensionUtil {
	Finnur 2012/04/24 13:03:24 Files and classes that end in Util tend to accumul Files and classes that end in Util tend to accumulate junk over time. In this case, however, I'm not even sure a separate file for this util function is warranted since this function isn't shared with any other code. You could just put it in a namespace {} at the .cc file where you use it and if we need to share it elsewhere we can always move it. Sam Kerner (Chrome) 2012/04/24 15:27:54 This is used in external_filesystem_extension_load Show quoted text On 2012/04/24 13:03:24, Finnur wrote: > Files and classes that end in Util tend to accumulate junk over time. In this > case, however, I'm not even sure a separate file for this util function is > warranted since this function isn't shared with any other code. You could just > put it in a namespace {} at the .cc file where you use it and if we need to > share it elsewhere we can always move it. This is used in external_filesystem_extension_loader_linux.cc and external_pref_extension_loader.cc .
	17 public:

	18 static base::DictionaryValue* ExtractPrefs(const FilePath& path,

	19 base::ValueSerializer* serializer);
	Finnur 2012/04/24 13:03:24 Can we use the WARN_ON_UNUSED_RESULT macro for thi Can we use the WARN_ON_UNUSED_RESULT macro for this function?
	20 };
	Finnur 2012/04/24 13:03:24 It feels like this should be a namespace and not a It feels like this should be a namespace and not a class... No? Also, the function is missing comments (see my comment in .cc file).
	21

	22 #endif // CHROME_BROWSER_EXTENSIONS_EXTERNAL_EXTENSION_UTIL_H__

	23

OLD	NEW