Issue 10178030: Added lib/compiler compile all VM benchmark.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10178030: Added lib/compiler compile all VM benchmark. (Closed)

Created:
8 years, 8 months ago by siva

Modified:
8 years, 7 months ago

Reviewers:
cshapiro

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Added lib/compiler compile all VM benchmark. Added frame lookup VM benchmark. Committed: https://code.google.com/p/dart/source/detail?r=7175

Patch Set 5 : #

Created: 8 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+177 lines, -12 lines)			Patch
M	bin/bin.gypi	View	1 2 3 4	2 chunks	+10 lines, -1 line	0 comments	Download
M	vm/benchmark_test.cc	View	1 2 3 4	6 chunks	+131 lines, -3 lines	0 comments	Download
M	vm/unit_test.cc	View	1 2 3 4	2 chunks	+36 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

cshapiro

LGTM - but fix lint warnings, &c http://codereview.chromium.org/10178030/diff/5/vm/benchmark_test.cc File vm/benchmark_test.cc (right): http://codereview.chromium.org/10178030/diff/5/vm/benchmark_test.cc#newcode30 vm/benchmark_test.cc:30: /* "// ...

8 years, 7 months ago (2012-05-01 00:37:24 UTC) #2

siva

8 years, 7 months ago (2012-05-01 00:59:48 UTC) #3

http://codereview.chromium.org/10178030/diff/5/vm/benchmark_test.cc
File vm/benchmark_test.cc (right):

http://codereview.chromium.org/10178030/diff/5/vm/benchmark_test.cc#newcode30
vm/benchmark_test.cc:30: /*
On 2012/05/01 00:37:24, cshapiro wrote:
> "// ..." comments instead of "/* ... */" for consistency with the rest of the
> C++ code?

Done.

http://codereview.chromium.org/10178030/diff/5/vm/unit_test.cc
File vm/unit_test.cc (right):

http://codereview.chromium.org/10178030/diff/5/vm/unit_test.cc#newcode11
vm/unit_test.cc:11: #include "bin/builtin.h"
On 2012/05/01 00:37:24, cshapiro wrote:
> Trivial but, usually includes are ordered by the directory so the bin stuff
> should go first on line 9.
> 
> http://www.corp.google.com/eng/doc/cppguide.xml#Names_and_Order_of_Includes

Done.

Expand Messages | Collapse Messages

Issue 10178030: Added lib/compiler compile all VM benchmark. (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Messages